pijyoi

Results 145 comments of pijyoi

Looking at the documentation, for opacity: https://doc.qt.io/qt-5/qgraphicsitem.html#setOpacity It seems that if you really want to save what appears on screen, you would need effectiveOpacity() instead. So if we go back...

So the difference between ImageItem::save() and NewImageItem::save() is that the former saves the image that has passed through pyqtgraph library processing (downsampling, contrast stretching, colormapping, etc), whereas the latter wants...

@ntjess given that you have already invested time modifying the code to fix what you perceive as a bug, you could raise a PR for a review. I don't use...

Your test script works without error with the current PR #2955

The code chunk actually comes from `functions::makeARGB()`: https://github.com/pyqtgraph/pyqtgraph/blob/21391e08a3f93aaf83ab22af642dabfa85e00e25/pyqtgraph/functions.py#L1441-L1462 Back then, the goal was to make the code behave the same as `makeARGB()`. I would replace it with the following: ```python...

`test_PolyLineROI` failure also reported in #2110 for aarch64, ppc64le. ``` > assertImageApproved(plt, 'roi/polylineroi/' + name + '_click_segment', 'Click mouse over segment.') ``` This is the current failure point as documented...

From what I understand from the error logs and https://github.com/pyqtgraph/pyqtgraph/blob/4544539370e5f80e9c79f5a99a127e728f42650f/tests/test_makeARGB.py#L3198 the test input of `array([[ inf, 0.53662884, nan, 0.8853132 ]` got mapped on your machine to `array([[[255, 255, 255, 255],...

Apparently, conversion of `nan`s to `int` is an undefined operation in the C standard. https://stackoverflow.com/questions/10366485/problems-casting-nan-floats-to-int I don't think it should be `pyqtgraph`'s job to make that undefined behavior defined. If...

You may be interested in #2960, where it is demonstrated that pre- creating QBrushes is the fast way.

As an example, #2709 disabled anti-aliasing for horizontal and vertical infinite lines. I think perhaps the issue may have to do with the combination of opacity + anti-aliasing + hidpi?...