Pietro Vertechi

Results 220 comments of Pietro Vertechi

So, with some order, here is the actionable MakieCon feedback. ## Usability issues - Legends and labelling. - [ ] Provide helpers for customizability (mix and match with existing Makie...

Sorry to just bump this, but I've also run into https://github.com/FluxML/Zygote.jl/issues/899 and wanted to check whether this can be solved. As https://github.com/JuliaMath/FFTW.jl/pull/249 has been merged, would it be possible to...

This seems like a pretty large PR (though in general I think I'm happy with most changes, it makes sense to unify the implementation of shifted and circularly shifted arrays....

> I somehow wonder, if one should create an Abstract Superclass from which both derive? Yes, this seems like a cleaner solution if one wants to share functionality. The current...

Of course it can be helpful if @roflmaostc can review the code, but I think it would greatly simplify things if we tried to break this PR into more manageable...

@RainerHeintzmann sorry for the very slow reply rate in this PR! I can see that a lot of work already went into this, and it'd be definitely very useful to...

> So how do we continue now? I think the first thing to do is to turn the snippet from https://github.com/JuliaArrays/ShiftedArrays.jl/pull/66#issuecomment-1699096724 (and the analogous for `CircShiftedArrays`) into a PR (feel...

> OK. I did already write that code and I am happy to do a new PR, but only in about two weeks, if that's OK. Sounds great!

This does create some headaches, esp. in IndexedTables, which uses this machinery. In particular, I need to allow the awkward `collect_structarray(itr, state)` method for technical reasons (I got rid of...

The easiest for now would be to fix the error you see. The problem is that it tries to build a `StructArray` of eltype `Union{}` which is not possible. I...