InteractBase.jl
InteractBase.jl copied to clipboard
piever
Update dialog JavaScript for newer Electron API
This PR fixes the open/save dialog functionality for the latest version of the Blink package. Even after fixing the undefined variables, differences in the security model of newer versions of Electron meant that a few tweaks were necessary to ensure compatibility.
This patch is co-dependent on an update to Blink.jl, as well. Merging PR JuliaGizmos/Blink.jl#309 and updating the compatibility constraints for Project.toml may be necessary to prevent the potential for users to end up with a broken project.
This patch supplements the resolution to JuliaGizmos/Interact.jl#414 (in piever/InteractBase.jl#176) to fix an additional complication arising from the updated Electron in Blink.jl.
| Blink.jl | InteractBase.jl | Status |
|---|---|---|
| Blink v0.12.5 (Electron 4.04) | InteractBase v0.10.5 | Working |
| Blink v0.12.5 (Electron 4.04) | InteractBase v0.10.9 | Broken (theme undefined) |
| Blink v0.12.5 (Electron 4.04) | InteractBase #177 | Working |
| Blink v0.12.5 (Electron 4.04) | InteractBase #178 | Broken (no dialog) |
| Blink.jl | InteractBase.jl | Status |
|---|---|---|
| Blink v0.12.6 (Electron 19.09) | InteractBase v0.10.9 | Broken (theme undefined) |
| Blink v0.12.7 (Electron 19.09) | InteractBase v0.10.9 | Broken (theme undefined) |
| Blink v0.12.7 (Electron 19.09) | InteractBase #177 | Broken (no dialog) |
| Blink #309 (Electron 19.09) | InteractBase #177 | Broken (no dialog) |
| Blink #309 (Electron 19.09) | InteractBase #178 | Working |
This would be very useful for solving a bug in our user interface in the Koma.jl package. Is there any news on this @mosullivan93?
