UpdateChecker icon indicating copy to clipboard operation
UpdateChecker copied to clipboard

Published 20 hours ago • verified publisher icon pietrorampini

Are you serious?

Open stan-ko opened this issue 9 years ago • 1 comments

You keep an Activity in a static reference in UpdateChecker class - are you an Android developer really?

stan-ko avatar Feb 05 '16 15:02 stan-ko

Agreed. Everything is needlessly static. Although, there's nothing wrong with that but if you're going to go down that road then a public static init() method is more appropriate than using a constructor. Not to mention the static activity reference is passed on to an AsyncTask without any attempts at cleaning up which could lead to memory leaks.

Aditya94A avatar Jun 13 '16 14:06 Aditya94A