nimib icon indicating copy to clipboard operation
nimib copied to clipboard

Published 20 hours ago • verified publisher icon pietroppeter

nbJs Maintainance

Open HugoGranstrom opened this issue 2 years ago • 1 comments

Fixes #122, ~~118~~, #124, #127

  • [x] Separate untyped and string versions of nbCodeToJs (the body doesn't have to be type-checked anymore)
  • [x] Rename nbCodeToJs to nbJsFromCode and nbJsFromString
  • [x] Respect {.exportc.} when mangling names
  • [ ] ~~Use separate mangling table for each script~~
  • [x] nbKaraxCode postRender template

HugoGranstrom avatar Aug 02 '22 18:08 HugoGranstrom

It took a while but most of the things are done now. The problem of interlaced code blocks I will leave for a later PR as I'm not sure how to solve it best yet.

HugoGranstrom avatar Aug 17 '22 17:08 HugoGranstrom

so basically this was ready some time ago but now it seems really ready :) should I give a quick review and merge?

pietroppeter avatar Sep 09 '22 16:09 pietroppeter

Haha yes :) That would be appreciated, the most important thing being if I named everything new sensibly

HugoGranstrom avatar Sep 09 '22 16:09 HugoGranstrom

as discussed in zoom call, we should add deprecation messages

pietroppeter avatar Sep 10 '22 10:09 pietroppeter

I think this was what we agreed on. Correct if I'm wrong :)

HugoGranstrom avatar Sep 10 '22 14:09 HugoGranstrom