Pietro Albini

Results 174 comments of Pietro Albini

Well, that's surely an option (and that would probably also improve compression ratio if we gzip them). I think it's out of scope for this issue though, which can be...

@chaosteil hey! Did you make any progress on this? Do you need some help?

Yep, that was my plan. My only doubt is what should Crater do if the upload to S3 fails. At the moment this is not a problem, because all the...

Just for reference, the graph thing is implemented in #193, the only thing left to do is parsing the cargo dependency graph and adding edges between the crates in the...

Well, yeah, I didn't expect to implement proper support in time for the edition preview 2. Once there is a build with the `-Z` flag doing some patches on the...

I left [some notes](https://github.com/rust-lang-nursery/crater/blob/tmp-edition/docs/tmp-edition.md) to run rustfix runs with the temporary branch. It's not possible to run them at the moment since enabling the `rust_2018_preview` feature flag breaks rustfix while...

@aidanhs it sort of reduces the impact, because there are NUM_THREADS target directories instead of one for each toolchain. The solution for this is to lock the target directory while...

I also agree this isn't needed: the `build`/`test` split exists because one it's a compiler error and the other is a logic error, but both `build` and `test --no-run` are...

> every now and again, do a recheck run of all crates with a disabled stage to see if they've been fixed Maybe we can do a recheck on the...

With run-graph (and some changes that will soon be merged) most of the code to automatically mark dependent crates as regressed is already in place. The only two things that...