Pietro Albini

> Do you have any links to existing crater PRs that include Cargo.toml introspection? The `Cargo.toml` changes are done here in Crater: https://github.com/rust-lang-nursery/crater/blob/master/src/runner/toml_frobber.rs

This PR looks good! Thanks for working on this Mark :heart: > This PR, once deployed, will also presumably break r? on repositories that do not enable [assign] in the...

> I can add a key to it that gates just the r? behavior (i.e. not the "assign rustbot" piece); do we want that? I can't think of a repo...

You also need to change the message that highfive prints when a reviewer is assigned. Otherwise rustbot will react to highfive's `r? @foo`.

We're waiting for GitHub to implement [role-based access control](https://github.com/github/roadmap/issues/111), as that's needed to securely give triagebot access to all the repositories without any chance of privilege escalation.

I don't think mutable crate metadata needs to be downloaded by `cargo build` at all: that metadata is not needed for builds, and Cargo must not expose it to the...

> There are a ton of issues here, to list a few: [...] Thanks for the examples @Diggsey, I now agree that `cargo build` should not download that metadata! In...

> Would it be possible for this RFC to include the moderation team in it? AFAIK, our permissions are currently given on a very ad hoc basis. We are somewhat...

Unfortunately the permission levels GitHub offers are not really suited for us, and the moderation team would need write or admin access to every repository in the organization to properly...

@BurntSushi @nellshamrell well, the current snippet is not wrong, but it doesn't touch much on the last two paragraphs of my comment.