MapComplete icon indicating copy to clipboard operation
MapComplete copied to clipboard

Property `enableImproveAccuraccy` is not allowed.

Open tordans opened this issue 2 years ago • 3 comments

The validator shows this warning for nearly all themes.

Property enableImproveAccuraccy is not allowed.

      "allowMove": {
        "enableRelocation": false,
        "enableImproveAccuraccy": true
      },

I don't know if this is a missing key in the schema or if the key should be removed from all themes (and the schema is right…).

tordans avatar Apr 29 '22 08:04 tordans

I cannot find the string enableImproveAccuraccy in the codebase, so likely the schema is right and the theme files should be updated.

I wonder, is there a Github action in place that validates the themes against the schema from time to time?

tordans avatar Apr 29 '22 08:04 tordans

Hmmm, they are here and here

It is used here: https://github.com/pietervdvn/MapComplete/blob/1271f241603918db41a37c61f4222f9de8896c18/UI/Popup/MoveWizard.ts#L68

There is a script to update the scheme files though, is seems like it has been a while since I last ran it: npm run generate:schemas

pietervdvn avatar Apr 29 '22 23:04 pietervdvn

This being cleared, it might be a good idea to validate these schema files in the build script too, so that they are updated regularly.

Validating the theme and layer files against these schemas would be nice too. Is there a command line tool which does this?

pietervdvn avatar Apr 29 '22 23:04 pietervdvn