MapComplete icon indicating copy to clipboard operation
MapComplete copied to clipboard

Post partners and parcel lockers

Open RobinLinde opened this issue 2 years ago • 3 comments

Adds post partners and parcel lockers to the parcels theme. Also splits out the layers.

Post partners

  • Operators (with some country-specific mappings)
  • Services

Parcel lockers

  • Renders both new and old style
  • Brand (with some country-specific mappings)
  • Operator
  • Opening hours
  • Reference number

Current issues

RobinLinde avatar Aug 11 '22 12:08 RobinLinde

No way to upgrade tags of old-style parcel lockers (from amenity=vending_machine to amenity=parcel_locker

To be honest, it is not the task of mapcomplete to systematically remap old tagging into new tagging. MapComplete users typically don't know anything about tags in the first place. Retagging would thus boil down to a distributed mechanical edit - in which case a global mechanical edit would be better.

pietervdvn avatar Aug 17 '22 19:08 pietervdvn

Maybe this PR can be split into two parts: one for the parcel-lockers (which are pretty straightforward on first sight) and could be merged without an extensive review.

pietervdvn avatar Aug 17 '22 19:08 pietervdvn

I've now split out the parcel lockers into #1033

RobinLinde avatar Aug 18 '22 18:08 RobinLinde

I think the version as it is now workable, doesn't feature any way of adding post partners, but still allows viewing them, as well as adding details to them.

RobinLinde avatar Oct 11 '22 12:10 RobinLinde

Excellent work, as usual!

In order to add a post partner, maybe import the 'shops'-layer and override/add a tagRendering 'is this shop a post partner?'. By setting the minzoom on the imported layer on 18 or 19, the non-post-partner shops will only show up when zoomed in a lot. I did a quick overpass-query, and it seems that the post-partners are shops in about 95% of the cases; the remainder are often fuel stations (or rather: fuel station affiliated shops); so that should cover most of it.

pietervdvn avatar Oct 12 '22 22:10 pietervdvn