Pieter Marsman
Pieter Marsman
I prefer option 1 (just checking if the code does not raise an error) or 2 (check for specific output). If you go for two, we do indeed need to...
@richardpaulhudson Thanks for the all your work!
It is probably "so wrong" because the font subtype is something unexpected or unkown and the `PDFType1Font` is used as a default. Not sure if this clause is ever triggered....
This isn't the only strange comment though. A lot of comments also specify the name of the class that is defined after the comment. Could you make a list of...
I agree with you that `laparams=None` does not give the best result and therefore is a terrible default. However, changing it would be a breaking change with earlier releases. I...
If you like you can create a pull request that does that. Then we also have something concrete to talk about.
Yes it is. I think it is most prone in `extract_text_to_fp`. - It uses `laparams=None` as a default. Other high level function use `laparams=LAParams()` if nothing is specified. - It...
Maybe deprecate and remove `extract_text_to_fp` entirely? I've never liked it that you hand it an output stream and it writes the result to it. And we have better high-level function...
So plan of attack: - Raise warnings when using `extract_text_to_fp` * A deprecation warning because the function will be removed in the future (when? 2021?) * A warning if `laparams=None`...
@damo1808 can you share the code and version of pdfminer.six you are using? There were some fixes for this in https://github.com/pdfminer/pdfminer.six/pull/689.