heemod icon indicating copy to clipboard operation
heemod copied to clipboard

Reduce code bottlenecks

Open pierucci opened this issue 8 years ago • 6 comments

Bottlenecks significantly reduce the speed of iterative functions for heterogeneity and probabilistic analysis. They should be identified and improvements should be suggested.

pierucci avatar Dec 27 '15 17:12 pierucci

Compiling functions with compiler::enableJIT() actually slows down the code...

pierucci avatar Dec 27 '15 17:12 pierucci

Biggest bottleneck: do_() call in eval_matrix().

pierucci avatar Jan 19 '16 17:01 pierucci

This was actually (partially) addressed in a recent update. Sped up the do_() call in eval_matrix by around 4x. Of course there is always more to do. It might be useful to reprofile the code.

MattWiener avatar Sep 27 '16 07:09 MattWiener

I agree, thanks a lot for that! Furthermore bc84686d7aa4734c555a754e55be703805370660 added another 2x time speedup by running check_matrix() only once on a 3-D array instead of repeating it over 2-D matrices.

I'll still keep this issue open though to track codes bottlenecks elsewhere in the code.

pierucci avatar Sep 29 '16 11:09 pierucci

I suspect we could gain time in split_along_dim().

pierucci avatar Sep 29 '16 11:09 pierucci

partially addressed by pull request #140.

MattWiener avatar Sep 29 '16 13:09 MattWiener