piersy

I've reopened this issue because I'm seeing lots of flaky tests in CI. All these tests went green simply by being re-run some number of times. Current offenders are: *...

Also seeing this test [TestUDPv4_LookupIterator ](https://app.circleci.com/pipelines/github/celo-org/celo-blockchain/6646/workflows/178b3d6d-d143-424f-a37f-00b60d06c211/jobs/64830) failing randomly

Aslo TestAnnounceGossipQueryMsg TestPrepare https://app.circleci.com/pipelines/github/celo-org/celo-blockchain/7026/workflows/a702ac16-f5b6-4f1d-9254-11b6f02d17a7/jobs/69372

Also TestUDPv4_responseTimeouts TestWSAttachWelcome https://app.circleci.com/pipelines/github/celo-org/celo-blockchain/7144/workflows/7e22a2ca-2b54-4456-8d18-74a849e64376/jobs/71091

Also TestIPCAttachWelcome https://app.circleci.com/pipelines/github/celo-org/celo-blockchain/7144/workflows/7e22a2ca-2b54-4456-8d18-74a849e64376/jobs/71092

Also TestPriorityClient https://app.circleci.com/pipelines/github/celo-org/celo-blockchain/7152/workflows/7c6882af-6a38-49b6-8087-811622d69255/jobs/71223 ``` === RUN TestPriorityClient test_cmd.go:250: (stderr) INFO [10-22|12:41:09.086] Maximum peer count ETH=175 LES=0 total=175 test_cmd.go:250: (stderr) ERROR[10-22|12:41:09.086] Failed to enumerate USB devices hub=ledger vendor=11415 failcount=1 err="failed to...

Also TestStartStopValidators - https://app.circleci.com/pipelines/github/celo-org/celo-blockchain/7232/workflows/1f60a0c6-dae3-4492-ba0a-c5743de15e0b/jobs/72398 It timed out after 46 seconds, normally it runs on my machine in 12 seconds. So i think this could be a deadlock that appears to...

Further TestPrepare [fail](https://app.circleci.com/pipelines/github/celo-org/celo-blockchain/7871/workflows/0aea30f5-9ee7-47ed-8a7a-52c2d6c860f0/jobs/81510) today (actually I think this is only happening because the fix #1792) did not make it into the `v1.5.x` release branch) ``` === RUN TestPrepare panic: runtime...

Coverage from tests in `./e2e_test/...` for `./consensus/istanbul/...` at commit ddf8ea176126cbf005a2788b8132822dce98bcde coverage: 51.6% of statements across all listed packages coverage: 61.4% of statements in consensus/istanbul coverage: 43.1% of statements in consensus/istanbul/announce...

Coverage from tests in `./e2e_test/...` for `./consensus/istanbul/...` at commit f25b3786677c7658134fa863585262963f5bbe96 coverage: 49.6% of statements across all listed packages coverage: 61.3% of statements in consensus/istanbul coverage: 42.9% of statements in consensus/istanbul/announce...