consul-rust icon indicating copy to clipboard operation
consul-rust copied to clipboard

Published 20 hours ago • verified publisher icon pierresouchay

Make KV Value optional

Open fussybeaver opened this issue 5 years ago • 2 comments

The previous PR got conflated with other work that we were doing, so I've re-opened with the original fix for #24 and added a mockito test.

fussybeaver avatar Nov 19 '19 12:11 fussybeaver

Hello @fussybeaver ,

Sorry for the huge delay in reviewing this. Are you still interested in fixing it?

You are right, the value might be null, but more globally, the API is probably wrong regarding its semantics.

The big downside is that it will force us to create a breaking change, requiring us to bump the minor.

Please provide a rebase and I'll be glad to integrate it.

Regards

pierresouchay avatar Apr 27 '21 20:04 pierresouchay

Hi @pierresouchay , thanks for picking this up again..

fussybeaver avatar Apr 30 '21 05:04 fussybeaver