Pierre Prinetti

I would be opposed to adding to Gophercloud a function that accepts a string that can equally be uuid or name. I’d let that guesswork to the caller application

On the other hand, goohercloud/utils was created specifically to host this kind of code 😁

Good catch, thanks. I would remove the argument in seconds and let the caller pass a context with a deadline. The predicate function should also accept a context, so that...

> i found it handy option to pass a timeout The `context` library [provides a convenience function for setting a timeout](https://pkg.go.dev/context#WithTimeout). Note that if you set a deadline or timeout...

My stance here is: this is not Gophercloud's job. There are plenty of libraries out there that do Wait in fanciful ways. I understand that we might continue providing a...

There's a race. Your select statement is a bit funky, in that it could trigger an unbound number of predicate calls. Your implementation makes sure that a function is called...

Can you please squash and rebase? @mandre has been fixing most of the CI errors in the master branch.

@vooon we may have issues here: internal/acceptance/openstack/containerinfra/v1/nodegroups_test.go https://github.com/gophercloud/gophercloud/actions/runs/8237438492/job/22526174282?pr=2957#step:5:969

Nice! Thank you @vooon and @mandre for the additional review. I think we can merge as soon as we get the CI's blessing

I am working on leveraging errors.Unwrap, which should bring the same benefits: https://github.com/gophercloud/gophercloud/pull/2906