Pierre Prinetti
Pierre Prinetti
I have a last-minute doubt about this PR. see https://github.com/gophercloud/gophercloud/issues/2872#issuecomment-1900099365
Thank you for this high-quality report featuring a minimal reproducer!
Actually, your reproducer is misleading. The first line (where you pass a pointer to a pointer to `TestPerson` (`**TestPerson`) correctly errors. For reference: https://go.dev/play/p/XN6nHpe52yp Could you find a case where...
@bobuhiro11 By any chance: have you hit a panic in some real-world application of this code?
> I'm seeing random timeouts and quota issues, but I'm not sure if this is due to this PR or infra issues. @pierreprinetti wdyt? yes, the CI results are compatible...
> some people still use these since they can be seen as "easier" to use that the proper APIs. While we removed the code for those APIs from novaclient when...
Nice addition, thanks
> Note that I didn't set the `--base v2` option when submitting this so it's merging into `master`. If this is indeed supposed to be merged into `v2`, I'd ask...
I personally prefer the first approach: the one where the scheduler hints are conflated into the existing `createOpts`. My rationale for that is: `createOptsBuilder` is an interface that outputs URL...
we have that sort of functionality in utils at the moment: https://github.com/gophercloud/utils/blob/master/openstack/compute/v2/servers/utils.go I would not be opposed to having some clever generic replacement for that in the main library.