Pierre du Plessis

Results 170 comments of Pierre du Plessis

@rimas-kudelis Well there won't be anything to provide from external apps. E.G in the `payum/paypal-express-checkout-nvp` package, we would just require Guzzle 7 and use the Guzzle client inside that package,...

> I believe the choice between Guzzle vs something else should be left to your downstream users. While I agree with this, I also don't want users to have to...

This has been done in #975, using a PSR-18 Http client using `php-http` client discovery, so you are free to use any implementation you want. And based on https://github.com/php-http/discovery/pull/208, a...

Thanks for the PR. This changes has already been made in #976.

@ViniTou The checks are correct. When a payment is initiated, the `PAYMENTREQUEST_` values are set and sent to PayPal. Once the payment on PayPal is done and the user is...

If there are any other issues, please feel free to re-open the issue and add additional detail

Actually I'm considering re-adding the interfaces and classes that wads removed, and keeping the current config names. I'm trying to minimise breaking changes for V2, so that all external plugins...

There are hundreds of custom gateways available that might not all get updated to support V2, so releasing a new major version with no compatible gateways (except the built-in ones)...

> as a fan of semver, I just have that habit of associating major releases with API breakage and not seeing it as a bad thing According to Semver, when...

I have made the following changes to the PR: * Keep the `httplug.*` config options, but trigger a deprecation notice * Added `payum.http_*` options to replace the httplug options, which...