ferris icon indicating copy to clipboard operation
ferris copied to clipboard

Investigate IBOM on Safari not working

Open peauters opened this issue 3 years ago • 2 comments

peauters avatar Apr 22 '21 10:04 peauters

Hi @pierrechevalier83,

I have encountered issue of iBOM not working for any browser. issue lies in this regex check on lines 3020 - 3021

  document.getElementById("github-link").innerHTML = "InteractiveHtmlBom " +
    /^v\d+\.\d+/.exec(pcbdata.ibom_version)[0];
}

problem is that pcbdata.ibom_version is "ferris_release_4\n" but regex expects it to be something like this "v2.3-50-g53ae\n"

so could you please fix it :)

DrMagPie avatar Jun 04 '21 10:06 DrMagPie

Thanks @DrMagPie, this is a very helpful observation. Reading the generate_ibom_html code, I can see that some of the code assumes it is run from their own github repo and tries to pull metadata from git. This fails in the way I use it as I am using their repo as a submodule. I think a fix may be to modify the script upstream to allow overriding the version with a command line argument. Will discuss it upstream.

pierrechevalier83 avatar Jun 04 '21 12:06 pierrechevalier83