node-lz4 icon indicating copy to clipboard operation
node-lz4 copied to clipboard

install script overwrites build/lz4.js

Open MPickfield opened this issue 5 years ago • 1 comments

The script "install": "node-gyp rebuild", in the package.json overwrites build/lz4.js on install, meaning that when you npm install the package the web version may be unavailable.

This may only have been an issue for me because I have a hybrid webpack project that outputs both a node-based cli tool and a browser ready package.

A solution could be to change the browserify output to another folder and change the "browser" entry in package.json to point there instead. build/ could then be added to .gitignore so that the node build doesn't accidentally get added.

MPickfield avatar May 12 '20 18:05 MPickfield

Thanks for reporting. Please send a PR if you need it.

pierrec avatar May 15 '20 17:05 pierrec