Pierre Curto

Results 77 comments of Pierre Curto

Totally agree. Want to send a pull request?

Hi @sten0, sorry for not addressing the other issues, I maintain this lib on my freetime, and it has been very scarce! I have updated the header of that file...

@xguo-prestolabs thanks for the report. I would be keen on getting the file uncompressed version though as the bug may be a variety of places. I would understand if you...

Would the following error be good enough? This is an easy fix. > x.json2.InvalidTokenError: [x.json2] invalid token `str_`, expecting `comma` (13:17)

Hello, sorry for the late response. I am no longer using Node and not following its updates/developments anymore. I would accept a PR though to fix this issue!

After using this API a bit, I think the following would be better as it avoids copying: ``` /// Peeks the next `n` bytes without advancing the reader. /// The...

> Why do you want it to be possible to provide a buffer that is too small? > ... > > With this code, the buffer is provided by the...

> I think this function should additionally assert that dest.len is > How about a more convenient API instead? > > ```zig > pub const PeekError = Error || error{EndOfStream};...

Very late replay - sorry. I have no idea :). I would suspect the answer is yes but have no time to test it out. If you did could you...

Very good thank you. Some tests do fail though I will double check why when I have some time.