angular-tabler-icons icon indicating copy to clipboard operation
angular-tabler-icons copied to clipboard

Update to support angular 18

Open gwentey opened this issue 1 year ago • 11 comments

Currently version 3.1.0 is not working with angular v18.

npm error code ERESOLVE npm error ERESOLVE unable to resolve dependency tree npm error npm error While resolving: [email protected] npm error Found: @angular/[email protected] npm error node_modules/@angular/common npm error @angular/common@"18.2.13" from the root project npm error npm error Could not resolve dependency: npm error peer @angular/common@"14 - 17" from [email protected] npm error node_modules/angular-tabler-icons npm error angular-tabler-icons@"3.1.0" from the root project npm error npm error Fix the upstream dependency conflict, or retry npm error this command with --force or --legacy-peer-deps npm error to accept an incorrect (and potentially broken) dependency resolution. npm error npm error

gwentey avatar Dec 08 '24 14:12 gwentey

Hi, please use latest version of the package: npm install [email protected]

pierreavn avatar Dec 08 '24 14:12 pierreavn

Hello, I already tried but the lastest version use : linkedSignal and it doesn't exist in angular 18

[INFO] ./node_modules/angular-tabler-icons/fesm2022/angular-tabler-icons.mjs:64:16-28 - Error: export 'linkedSignal' (imported as 'linkedSignal') was not found in '@angular/core'

thanks

gwentey avatar Dec 08 '24 14:12 gwentey

Same problem here, none of the 3.X versions work with angular 18 as they all cause that same error.

molinet avatar Dec 08 '24 15:12 molinet

Same problem .... Same problem... and I don't know what to do my application in production has been down for 2 days...

demotey avatar Dec 09 '24 14:12 demotey

Latest version is indeed for angular >= 19 Should have made that more clear.

@pierreavn, should I add this to the readme (and supported versions). And maybe release a 4.x -> Breaking change?

With Angular 18, you should downgrade.

With 3.1.x you can use the allowVersions in your package.json when using pnpm

For example:

"pnpm": {
    "peerDependencyRules": {
      "allowedVersions": {
        "angular-tabler-icons>@angular/common": "18",
        "angular-tabler-icons>@angular/core": "18"
      }
    }
  },

With npm this should work:

"overrides": {
  "angular-tabler-icons": {
    "peerDependencies": {
      "@angular/common": "18.x",
      "@angular/core": "18.x"
    }
  }
}

Or use npm i --legacy-peer-deps (for now)

the-ult avatar Dec 10 '24 10:12 the-ult

Latest version is indeed for angular >= 19 Should have made that more clear.

@pierreavn, should I add this to the readme (and supported versions). And maybe release a 4.x -> Breaking change?

With Angular 18, you should downgrade.

With 3.1.x you can use the allowVersions in your package.json when using pnpm

For example:

"pnpm": {
    "peerDependencyRules": {
      "allowedVersions": {
        "angular-tabler-icons>@angular/common": "18",
        "angular-tabler-icons>@angular/core": "18"
      }
    }
  },

With npm this should work:

"overrides": {
  "angular-tabler-icons": {
    "peerDependencies": {
      "@angular/common": "18.x",
      "@angular/core": "18.x"
    }
  }
}

Or use npm i --legacy-peer-deps (for now)

It works ! thanks

gwentey avatar Dec 10 '24 16:12 gwentey

Latest version is indeed for angular >= 19 Should have made that more clear.

@pierreavn, should I add this to the readme (and supported versions). And maybe release a 4.x -> Breaking change?

With Angular 18, you should downgrade.

With 3.1.x you can use the allowVersions in your package.json when using pnpm

For example:

"pnpm": {
    "peerDependencyRules": {
      "allowedVersions": {
        "angular-tabler-icons>@angular/common": "18",
        "angular-tabler-icons>@angular/core": "18"
      }
    }
  },

With npm this should work:

"overrides": {
  "angular-tabler-icons": {
    "peerDependencies": {
      "@angular/common": "18.x",
      "@angular/core": "18.x"
    }
  }
}

Or use npm i --legacy-peer-deps (for now)

Indeed you right y'all.

I never used npm overrides, @the-ult if you have time, could you do a PR explaining this in README? it would be awesome.

pierreavn avatar Dec 18 '24 19:12 pierreavn

I'll try to make some time during the holidays/vacation. Add some tests and improve readme

the-ult avatar Dec 18 '24 21:12 the-ult

Really, no update since 5 Months using a LTS Angular version ...

rsmvdl avatar Apr 09 '25 07:04 rsmvdl

  • https://github.com/pierreavn/angular-tabler-icons/pull/152
  • https://github.com/pierreavn/angular-tabler-icons/pull/151

I'll update the version again tonight. But @pierreavn should approve them

the-ult avatar Apr 09 '25 12:04 the-ult

Im still running into this same issue with angular 18.2.12 and angular-tabler-icons 3.24.0 and 3.26.0. I have the overrides in my package.json file so i am not sure whats going on. Any help would be greatly appreciated.

janstadt avatar Jul 21 '25 20:07 janstadt