PlantUmlClassDiagramGenerator icon indicating copy to clipboard operation
PlantUmlClassDiagramGenerator copied to clipboard

Added support for C# 9 record type

Open DrPepperBianco opened this issue 3 years ago • 9 comments

Fixed Issue #42

Added override for VisitRecordDeclaration to add suuport for C# records.

Records are added as class <<record>> to the PlantUML output.

Other than class record can have a parameter list. This creates a constructor with that parameter list as well as properties. I only added properties to the PlantUML output, but not the constructors.

I also updated the README.md accordingly.

DrPepperBianco avatar May 27 '21 07:05 DrPepperBianco

@pierre3 tagging for visibility.

Vivraan avatar Oct 13 '21 11:10 Vivraan

I'm also looking forward to record addition.

gromag avatar Nov 15 '21 18:11 gromag

Just tried to use this package in VSCode with records and got the following error image

When I built the repo with changes from the PR it worked just fine. As far as I'm concerned this PR looks good to merge 👍

dominikb avatar Dec 01 '21 12:12 dominikb

Is there a reason why this is being blocked?

MathieuDR avatar Feb 25 '22 10:02 MathieuDR

We need this support for C# records, too. This is crucial for all modern C# projects. @pierre3 could you merge this, please? I would be ever so grateful.

svdHero avatar Mar 23 '22 12:03 svdHero

@pierre3 tagging again for visibility.

Vivraan avatar May 23 '22 05:05 Vivraan

Hello, This branch has been marge with Main?

Benoit-FM-Shift avatar Aug 17 '22 10:08 Benoit-FM-Shift

Perhaps @DrPepperBianco could create a new nuget package with the updated code. As @pierre3 seems to be unavailble / not maining this anymore.

MathieuDR avatar Aug 17 '22 14:08 MathieuDR

Pinging for attention, again.

@DrPepperBianco @pierre3

Vivraan avatar Sep 11 '22 08:09 Vivraan

Thanks @DrPepperBianco. Do you feel comfortable opening issues in your repo & perhaps setting up a new nuget package feed?

MathieuDR avatar Oct 05 '22 15:10 MathieuDR

@DrPepperBianco Thank you for your patience.

I added test code and fixed some issues, and merged.

  • Added support for "record struct".
  • Fixed the issue that generics type properties are not output

b79b59eb837d49748afcc0637ddddd680e5cfef2

pierre3 avatar Oct 14 '22 09:10 pierre3