vSMR icon indicating copy to clipboard operation
vSMR copied to clipboard

Parsing issues crashes EuroScope

Open kusterjs opened this issue 5 years ago • 5 comments

An incorrect formated vSMR configuration file results in an error message followed by a crash of EuroScope. The displayed error message is suitable. However, the behaviour should be that the vSMR radar screen is not loaded (or closed again) and EuroScope keeps running. As the configuration is loaded upon the initialisation of a new vSMR radar display, the file can then be corrected (with ES still running) and then the vSMR display can be loaded properly. This issue is mainly related to debugging / editing configuration files. An undetected format error can occur quite quickly, and it's just annoying if the application has to be restarted. Such kind of plugin-design-based crashes should be prevented by the plugin itself.

kusterjs avatar Nov 20 '19 22:11 kusterjs

I'll see what can be done

Keanu73 avatar Dec 02 '19 23:12 Keanu73

That’s a good point and that was my initial aim when I wrote this plugin a few years ago, however I remember struggling to achieve that with ES’s framework, it might be possible though. If I can I will take a look.

Sent with GitHawk

pierr3 avatar Dec 07 '19 10:12 pierr3

I was thinking of maybe doing a valid config check before the CPlugin object is passed to EuroScope, therefore not loading the plugin until the config is valid, though not sure if it's the best way to go about it..

Keanu73 avatar Dec 07 '19 13:12 Keanu73

@pierr3 I created some workaround with a default config. EuroScope & vSMR now load correctly without any customization. Nothing will be displayed beside the Topbar, the Inset and Euroscope.

You might also want to apply (a version) of my commit to insert the parsing Error into the MessageBox. #e92a7e7

hpeter2 avatar Sep 04 '20 14:09 hpeter2

Thanks so much @hpeter2, I will check it out and properly attribute the change to you if I implement!

pierr3 avatar Sep 05 '20 17:09 pierr3