murmurHash3js icon indicating copy to clipboard operation
murmurHash3js copied to clipboard

Transfer npm Package

Open karanlyons opened this issue 5 years ago • 6 comments

Hey @pid!

I’ve recently(ish) finished a new version of murmurhash3.js that’s far better written and much more fully featured:

  • Written in TypeScript.
  • Packaged for npm.
  • Supports any JavaScript string.
  • Supports Uint8Array buffers for raw data.
  • Supports progressive hashing across all functions.
  • Adds comprehensive test suite with 100% code coverage.

Unfortunately I can’t publish it, because there aren’t any accurate names available that npm will accept, which is a tad ironic given that a handful of them are largely just one of my older, worse versions 😄

Given that this repo was a fork to wrap things for node, and that my new version takes care of that itself and adds a lot more of value, would it be possible for you to transfer the package to me? This new version is 100% API compatible with any previous version.

Otherwise I’m not actually going to be able to publish my work at all under the global scope, which kinda sucks. Thanks!

karanlyons avatar Jan 11 '20 22:01 karanlyons

What's your username on npmjs? Of course, I will give you access to the package!

pid avatar Jan 11 '20 22:01 pid

Thank you! It’s the same as it is here: karanlyons. Let me know if you need anything more from me to transfer it over.

karanlyons avatar Jan 11 '20 23:01 karanlyons

Hey, just saw the GitHub invite, but I don’t want to take over your repo here, just the package at npm. All the actual commit history for the project is in the original repo, and it’d probably make the tree very confusing if we started merging downstream into a fork, plus I think you should be able to keep this repo around for historical reasons :)

karanlyons avatar Jan 11 '20 23:01 karanlyons

Added you to GitHub for a reason, so you can edit the readme to inform the users about the new repo for the new npm package.... a.s.o.

Feel free

pid avatar Jan 11 '20 23:01 pid

Oh, not a bad idea, you’re one step ahead 👍 Why don’t I just do that as a PR though, that way I also don’t end up accidentally committing to the wrong place in the future 😄 You can just accept that and then move this to readonly if you’d like.

karanlyons avatar Jan 11 '20 23:01 karanlyons

you can also replace the whole text... Really, feel free

pid avatar Jan 11 '20 23:01 pid