Pascal Craponne comments

Results 94 comments of


                                            Pascal Craponne

Try Catch aspect on async void method doesn't work

Tough one! The generated lamba is not a method, hence the non-detection. I tag this as a bug, even though I don't have any idea on how to fix this.

Try Catch aspect on async void method doesn't work

OK, it is actually a method, but I was excluded from weaving because it is compiler-generated and caused problems on release build. Still a bug anyway...

Try Catch aspect on async void method doesn't work

Hi @dougcunha, I didn't look at the generated code, however they probably change the code of the advised method in order to make it `async Task` instead of making it...

Try Catch aspect on async void method doesn't work

Also, they have a full team, paid by customers. On the other hand, I'm alone and work for free 😜

Try Catch aspect on async void method doesn't work

@dougcunha you missed the point in my answer; it was a smiling emoji. So no problem!

Try Catch aspect on async void method doesn't work

I replied ;)

Excluding properties weaving attribute on the level of class

You can try `[ExcludePointcut("*.get_@","*.set_@")]` on your advice, this will exclude methods whose name starts with `set_` and `get_` from it.

Excluding properties weaving attribute on the level of class

Did it work? If yes, you can close the issue.

Excluding properties weaving attribute on the level of class

Do you mean use the `[CompilerGenerated]` as a selection criterion? So for example we could include or exclude everything that was generated.

Excluding properties weaving attribute on the level of class

Yes, using the `[ExcludePointcut]` (or `[IncludePointcut]`).