moneybird-php-client icon indicating copy to clipboard operation
moneybird-php-client copied to clipboard

Product entity is missing a function and some parmeters

Open dario-dib opened this issue 3 years ago • 4 comments

Hi!

It looks like the Product entity is missing some parameters (title, identifier, product_type).

Also there is no function for /products/identifier/:identifier

Can you please add it? Or give me the permissions to create a branche/pull request? Thanks a lot!

/**

  • @var array */ protected $fillable = [ 'id', 'title', 'description', 'price', 'currency', 'frequency', 'frequency_type', 'tax_rate_id', 'ledger_account_id', 'identifier', 'product_type', 'created_at', 'updated_at', ];

/**

  • @param string|int $identifier

  • @return static

  • @throws ApiException */ public function findByIdentifier($identifier) { $result = $this->connection()->get($this->getEndpoint() . '/identifier/' . urlencode($identifier));

    return $this->makeFromResponse($result); }

.

dario-dib avatar Jul 30 '21 10:07 dario-dib

Yes, would be awesome if this could be added!

ralphjsmit avatar Aug 11 '21 11:08 ralphjsmit

@ralphjsmit I've forked it, since there is no reaction. Check : https://github.com/dario-dib/moneybird-php-client

dario-dib avatar Oct 18 '21 13:10 dario-dib

That's nice, thanks Dario!

ralphjsmit avatar Oct 18 '21 15:10 ralphjsmit

I've created a pull request for this issue

dario-dib avatar Oct 21 '21 09:10 dario-dib