exact-php-client icon indicating copy to clipboard operation
exact-php-client copied to clipboard

added methods for getQuotationLines and getQuotationOrderChargeLines

Open cihanarik opened this issue 1 month ago • 6 comments

those 2 is already existing for SalesOrders but was missing in Quotations

cihanarik avatar Dec 09 '25 20:12 cihanarik

@DannyvdSluijs I think those will come with a a future build by your script or not?

remkobrenters avatar Dec 10 '25 04:12 remkobrenters

@DannyvdSluijs I think those will come with a a future build by your script or not?

I can have a look tonight. Perhaps there is even more as it was some time ago. I’ll see if I can make some instructions for others to follow so it nog longer depends on just me.

DannyvdSluijs avatar Dec 10 '25 06:12 DannyvdSluijs

Cool thank you. @rubenwebparking do you think we can help with this? Maybe with some sort of automatic / triggered flow like we do for the webparking/logic4-client?

remkobrenters avatar Dec 10 '25 07:12 remkobrenters

Cool thank you. @rubenwebparking do you think we can help with this? Maybe with some sort of automatic / triggered flow like we do for the webparking/logic4-client?

Yes we can definitely make a GitHub Action which checks the documentation and updates the fields on a daily basis. Not sure how that would work in this project though as the generator lives in another repo, right?

rubenwebparking avatar Dec 10 '25 08:12 rubenwebparking

Sounds like a cool idea, I would not recommend daily though as there are hardly updates on a day to day basis and it puts some load on the documentation pages of someone else, perhaps a bi-weekly frequency would be better?

The tool I've made is https://github.com/DannyvdSluijs/PicqerExactPhpClientGenerator which could be installable through composer making it a candidate dev-depency? I'm more than happy to accept changes on the tool if needed.

DannyvdSluijs avatar Dec 10 '25 09:12 DannyvdSluijs

Looking at this PR with some more detail it seems we are adding the getters for the entity relations. This isn't something the generator does at this moment . So this PR should be merged in my opinion. The changes are like we can see in the SalesOrder (src/Picqer/Financials/Exact/SalesOrder.php)

DannyvdSluijs avatar Dec 12 '25 12:12 DannyvdSluijs

Thank you!

stephangroen avatar Dec 19 '25 09:12 stephangroen