alis icon indicating copy to clipboard operation
alis copied to clipboard

added shellcheck in workflow and updated all sh files

Open mfgbhatti opened this issue 2 years ago • 2 comments

Hi, I have added shellcheck config and updated all sh files with respect to shellcheck. Please note that this is not any update on functionality of alis script but just recommended change by shellcheck in script. I tried to add much information about it in the file.

mfgbhatti avatar Jul 14 '22 11:07 mfgbhatti

Hello @mfgbhatti, thanks for the PR, this is a nice feature to have for development and script quality.

I must review all changes and the conventions proposed by shellcheck, will take take me some time to review and give a try that all important things keep working.

picodotdev avatar Jul 15 '22 20:07 picodotdev

No worries.

mfgbhatti avatar Jul 18 '22 21:07 mfgbhatti

Merged in #220. Thanks for the PR!.

picodotdev avatar Sep 01 '22 20:09 picodotdev