pico icon indicating copy to clipboard operation
pico copied to clipboard

RTL not working with new "group"

Open comatan96 opened this issue 1 year ago • 2 comments

Please search for duplicate or closed issues first.

Describe the issue

RTL not working with new "group"

Current Behavior

For example. search button with wrong orientation: image

Expected Behavior

The search should be on the right and aligned

Reproduction URL

https://codepen.io/Matan-Cohen-the-decoder/pen/poXWzgz

Environment

Linux, latest pico, chrome Version 127.0.6533.72 (Official Build)

comatan96 avatar Aug 09 '24 17:08 comatan96

I believe this is due to use of physical properties in places like this: https://github.com/picocss/pico/blob/main/scss%2Fcomponents%2F_group.scss#L27-L36

Instead of left/right/top/bottom it should be inline-start/end/block-start/end. Corners are also possible.

I will raise a PR to fix this specifically. It is worth investigating the CSS as a whole for other uses of physical properties.

drmason13 avatar Aug 31 '24 06:08 drmason13

for anyone searching for a quick hacky fix, just flip the items and then add style="flex-direction: row-reverse;" to the fieldset.

3m4r5 avatar Oct 31 '25 11:10 3m4r5