pico icon indicating copy to clipboard operation
pico copied to clipboard

Fix SASS Deprecation Warning

Open indus opened this issue 1 year ago • 1 comments

Sass's behavior for declarations that appear after nested rules will be changing to match the behavior specified by CSS in an upcoming version. To keep the existing behavior, move the declaration above the nested rule. To opt into the new behavior, wrap the declaration in & {}.

More info: https://sass-lang.com/d/mixed-decls

There may be more locations where these changes should be made - but this one is the only one that gives an error in my codebase

indus avatar Jul 18 '24 06:07 indus

I came here to propose the same fix. Thanks for doing this already.

pauloxnet avatar Jul 19 '24 06:07 pauloxnet

@indus, I'm conflicted on this — while we do need to address this future breaking change, simply adding & {} everywhere results in multiple :root {} blocks in the final CSS. That makes the files harder to read, heavier, and could also lead to longer browser render times.

For now, I’ll silence the warning when compiling Sass. Open to revisiting if we find a cleaner way to handle it. sass --silence-deprecation=mixed-decls

lucaslarroche avatar Mar 09 '25 06:03 lucaslarroche

Hey @indus, after looking into this further, I found that @nstringham’s approach in PR #596 provides a clean solution by reordering declarations instead of adding extra & {} wrappers. This keeps the final CSS lighter and more readable.

I’ll likely move forward with that fix, but I appreciate your contribution and the discussion around this!

lucaslarroche avatar Mar 09 '25 12:03 lucaslarroche