pico icon indicating copy to clipboard operation
pico copied to clipboard

Better grouping of details content and summary dropdown

Open davidbgk opened this issue 2 years ago • 2 comments
trafficstars

  • [x] Please search for duplicate or closed issues first.

Describe the issue

Current Behavior

For now (v1 and v2) I find the details/summary elements to be a bit disconnected from the actual unfolded content, especially when using the role="button".

Capture d’écran, le 2023-09-27 à 19 00 13

Expected Behavior

That's the third time I add this to my custom CSS, it's just a suggestion of course:

details {
  border: 1px solid var(--secondary);
  border-radius: var(--border-radius);
  padding: var(--border-radius);
}
Capture d’écran, le 2023-09-27 à 19 01 26

Maybe it'll help somebody else, I can make a PR for that.

Reproduction URL

The documentation provides good examples:

  • https://picocss.com/docs/accordions.html
  • https://v2.picocss.com/docs/accordion

davidbgk avatar Sep 27 '23 23:09 davidbgk

I would prefer to keep it more neutral as is — not assuming the user prefer borders — but I would love to hear other user's thoughts.

lucaslarroche avatar Jan 27 '24 03:01 lucaslarroche

To be more precise, we did it after user testing and feedback on UX. Users were lost and did not understand the relation between the summary and the detail element. I get that a lighter theme is closer to the philosophy of the picocss default design but if it hurts usability it might not be the best option.

PS: really glad you're back 🤗

davidbgk avatar Jan 30 '24 01:01 davidbgk