pyicloud icon indicating copy to clipboard operation
pyicloud copied to clipboard

Making drive work properly

Open fivestones opened this issue 2 years ago • 5 comments

Proposed change

This is based on a previous PR (https://github.com/picklepete/pyicloud/pull/343/files) but done on the current drive.py main branch file. Hopefully it can be merged!

Without this PR, I can't actually see any of the files or sub-directories in any directory belonging to any apps (e.g., a 'Logseq' directory used by the Logseq iPhone app).

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New service (thank you!)
  • [ ] New feature (which adds functionality to an existing service)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests
  • [ ] Documentation or code sample

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • [x] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • [ ] Documentation added/updated to README

fivestones avatar Jun 26 '22 13:06 fivestones

Are there any maintainers still working on this project?

fivestones avatar Jul 03 '22 15:07 fivestones

Looks good to me. This PR extends the api.drive beyond iCloud Drive Documents to include all iCloud enabled apps. Hopefully @balloob can merge it.

RichieB2B avatar Jul 19 '22 13:07 RichieB2B

@balloob any chance of a merge for this?

fivestones avatar Aug 01 '22 13:08 fivestones

@balloob Can you merge this? Or are you willing to give some one else write access to this repo?

RichieB2B avatar Oct 28 '22 09:10 RichieB2B

Should merge this btw. Fixed my issue

rustanacexd avatar Feb 16 '23 17:02 rustanacexd