Add Delete/Upload

[jacobpgallagher]

Proposed change

Adds Delete and upload functionality.

Type of change

• [ ] Dependency upgrade
• [ ] Bugfix (non-breaking change which fixes an issue)
• [ ] New service (thank you!)
• [x] New feature (which adds functionality to an existing service)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests
• [ ] Documentation or code sample

Example of code:

photo_asset.delete()
api.photos.delete_many([photo_asset.asset_id])
api.photos.upload_file(file_path)

Additional information

I didn't add tests, as there wasn't a photo test yet set up. I can add it if necessary (and if I can find some time).

Checklist

• [x] The code change is tested and works locally.
• [x] Local tests pass. Your PR cannot be merged unless tests pass
• [x] There is no commented out code in this PR.
• [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [x] Documentation added/updated to README

[IanEdington]

I need this functionality.

@jacobpgallagher I'd be happy to get it over the line if needed.

@nzapponi, is there any interest in merging this PR?

[jacobpgallagher]

@IanEdington Feel free to take this and do whatever you want with it. I'm not sure what steps need to happen to get it merged.

[arendon17]

Hello @jacobpgallagher, in line 244 in photos.py, where does the dsid get added to self.params?

[jacobpgallagher]

As memory serves, that comes back with the initial authentication request. It wasn’t something I added, but between reading the photos api docs and trying to reverse engineer stuff that was what I found was necessary to make it work. This was all quite a while ago so my memory may be fuzzy or the api may have changed.

On Wed, Oct 5, 2022 at 12:02 PM Antonio Rendón @.***> wrote:

Hello @jacobpgallagher https://github.com/jacobpgallagher, in line 244 in photos.py, where does the dsid get added to self.params?

— Reply to this email directly, view it on GitHub https://github.com/picklepete/pyicloud/pull/354#issuecomment-1268833303, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKBGU7KTKI3YGX4CFFN2GDWBXGCRANCNFSM5GKIPYQA . You are receiving this because you were mentioned.Message ID: @.***>

[dubhunter]

@picklepete any chance of reviewing/merging this? This is the exact feature I am looking for.