pyicloud icon indicating copy to clipboard operation
pyicloud copied to clipboard

Adding alternative resOriginalAlt version to Photos

Open gdarruda opened this issue 4 years ago • 1 comments

Proposed change

Photos with RAW and JPEG needs an additional version key resOriginalAlt, adding it enables the use of RAW format files of photos.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New service (thank you!)
  • [x] New feature (which adds functionality to an existing service)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests
  • [ ] Documentation or code sample

Example of code:

for photo in api.photos.all:

    if 'alternative' in photo.versions:

        alternative = photo.versions['alternative']
        print(alternative['type'])
        print(alternative['url'])
   

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • [ ] Documentation added/updated to README

gdarruda avatar Jul 10 '21 13:07 gdarruda

This PR is superseded by https://github.com/picklepete/pyicloud/pull/347, which will ensure that edited versions can be downloaded in whatever resolutions are available.

jcass77 avatar Jun 18 '22 06:06 jcass77