Stack Overflow exception occurs on Android when using InternalStoragePathHandler

[speshiou]

• [x] I have read the Getting Started section
• [x] I have already searched for the same problem

Environment

Technology	Version
Flutter version	3.16.7
Plugin version	6.0.0
Android version	14

Device information: Google Pixel 6 Pro

Description

This issue wasn't discovered before 6.0.0-beta.31, but it was found after the upgrade to 6.0.0. After doing some research, it seems to be caused by this change (9cb8b3a).

The toMap function of WebViewAssetLoader calling itself recursively, then eventually causing a Stack Overflow exception. https://github.com/pichillilorenzo/flutter_inappwebview/blob/751a104716b2c5158b5cad58347430d01965f00d/flutter_inappwebview_android/lib/src/webview_asset_loader.dart#L197C8-L197C8

  @override
  Map<String, dynamic> toMap() {
    return {...toMap(), 'directory': directory};
  }

Expected behavior: No exceptions occur.

Current behavior: Stack Overflow occurs.

Steps to reproduce

1. Assign an InternalStoragePathHandler to InAppWebViewSettings
2. Navigate to the page that contains the WebView
3. The exception occurs

WebViewAssetLoader? webViewAssetLoader;
    if (Platform.isAndroid) {
      webViewAssetLoader = WebViewAssetLoader(
        pathHandlers: [
          AssetsPathHandler(path: '/assets/'),
          InternalStoragePathHandler(
            directory: await provider.draftBaseDir,
            path: "/$kAssetLoaderMappingDir/",
          ),
        ],
      );
    }

InAppWebViewSettings(
      // for android
      // Setting this off for security. Off by default for SDK versions >= 16.
      allowFileAccessFromFileURLs: false,
      // Off by default, deprecated for SDK versions >= 30.
      allowUniversalAccessFromFileURLs: false,
      // Keeping these off is less critical but still a good idea, especially if your app is not
      // using file:// or content:// URLs.
      allowFileAccess: false,
      allowContentAccess: false,

      // Basic WebViewAssetLoader with custom domain
      webViewAssetLoader: webViewAssetLoader,
      // for ios
      // allowingReadAccessTo: WebUri.uri(Uri.file(await provider.draftBaseDir)),
      isInspectable: kDebugMode,
    );

Stacktrace/Logcat

#11     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#12     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#13     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#14     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#15     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#16     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#17     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#18     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#19     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#20     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#21     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#22     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#23     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#24     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#25     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)
webview_asset_loader.dart:198
#26     AndroidInternalStoragePathHandler.toMap (package:flutter_inappwebview_android/src/webview_asset_loader.dart:198:16)

[github-actions[bot]]

👋 @speshiou

NOTE: This comment is auto-generated.

Are you sure you have already searched for the same problem?

Some people open new issues but they didn't search for something similar or for the same issue. Please, search for it using the GitHub issue search box or on the official inappwebview.dev website, or, also, using Google, StackOverflow, etc. before posting a new one. You may already find an answer to your problem!

If this is really a new issue, then thank you for raising it. I will investigate it and get back to you as soon as possible. Please, make sure you have given me as much context as possible! Also, if you didn't already, post a code example that can replicate this issue.

In the meantime, you can already search for some possible solutions online! Because this plugin uses native WebView, you can search online for the same issue adding android WebView [MY ERROR HERE] or ios WKWebView [MY ERROR HERE] keywords.

Following these steps can save you, me, and other people a lot of time, thanks!

[DougSig]

IIUC I believe the fix is as simple as making it call the super toMap - {...super.toMap(), 'directory': directory}