flutter_inappwebview fix: fixed Xcode 14 build error

fix: fixed Xcode 14 build error

Open CodeEagle opened this issue 2 years ago • 13 comments

Connection with issue(s)

Resolve issue #1216

Connected to #1216

Testing and Review Notes

Screenshots or Videos

To Do

[x] double check the original issue to confirm it is fully satisfied
[x] add testing notes and screenshots in PR description to help guide reviewers
[x] request the "UX" team perform a design review (if/when applicable)

Jun 29 '22 06:06 CodeEagle

@pichillilorenzo would you please review and merge this in? Right now, in the XCode beta, I have to manually edit the package file.

Jul 21 '22 21:07 mikhael28

Merge it, Works on XCode 14 Beta 4

Jul 29 '22 03:07 MrJohnDev

When will this be merged?

Sep 12 '22 21:09 sujithv28

When will this be merged?

Sep 13 '22 05:09 Attiv

When will this be merged?

Sep 13 '22 06:09 cimplesid

Until it is merged you can use

flutter_inappwebview:
    git: https://github.com/CodeEagle/flutter_inappwebview

and then run the following command

flutter pub get && cd ios && pod install

Sep 13 '22 06:09 cimplesid

Please merge it

Sep 13 '22 08:09 huylethanh

@cimplesid boss

Sep 13 '22 20:09 mikhael28

Please merge it, it works for me too

Sep 14 '22 01:09 j-ixcayau

@pichillilorenzo Please merge it

Sep 14 '22 05:09 acn-masatadakurihara

Anyone finding themselves with a conflict between the git dependency and a transitive dependency on the hosted flutter_inappwebview, can use this code in their pubspec.yaml:

dependency_overrides:
  flutter_inappwebview:
    git:
      url: https://github.com/CodeEagle/flutter_inappwebview

Sep 15 '22 19:09 calmog

Anyone finding themselves with a conflict between the git dependency and a transitive dependency on the hosted flutter_inappwebview, can use this code in their pubspec.yaml:
dependency_overrides:
  flutter_inappwebview:
    git:
      url: https://github.com/CodeEagle/flutter_inappwebview

Thanks, Buddy :)

Sep 15 '22 19:09 EricksonMoura45

Anyone finding themselves with a conflict between the git dependency and a transitive dependency on the hosted flutter_inappwebview, can use this code in their pubspec.yaml:
dependency_overrides:
  flutter_inappwebview:
    git:
      url: https://github.com/CodeEagle/flutter_inappwebview

Thank you. İts workly !

Sep 17 '22 00:09 emrementese

Any ETA as to when will this fix be merged? RN I need to add the dependency override to allow a build on iOS, but it breaks the build on Android, so I have to constantly go back and forth with adding/removing it.

Sep 18 '22 10:09 calmog

What is the ETA on when this fix be merged?? Currently i am not able build the app for iOS without this fix.

Sep 19 '22 09:09 sowmitri123

Another workaround: Set deployment target for pods and project to iOS 14.

May or may not be a good workaround for you, just dropping it here.

It's a good one for me, because I need WASM support from inapp_webview, and on iOS the earliest version of iOS that supports WASM in JavaScriptCore is iOS 14. So now I have 2 reasons to require 14 as the minimum version. Previously the app would show an error dialog asking users to upgrade, now it just won't run at all on 13 and below.

Sep 20 '22 07:09 n13

Please merge this. I would appreciate not implementing in a workaround when the solution exists!

Sep 20 '22 22:09 charlieforward9

@pichillilorenzo

This PR fix solved it for us too. Please MERGE as soon as possible.🙏🙇‍♂️

Sep 21 '22 05:09 Yokoi-K

Merge, please.....

Sep 22 '22 08:09 duy-mai-otsv

This is a blocker and should be fixed ASAP.

Sep 23 '22 14:09 anggrayudi

Until it is merged you can use
flutter_inappwebview:
    git: https://github.com/CodeEagle/flutter_inappwebview
and then run the following command
flutter pub get && cd ios && pod install

It works