node-gitlab-2-github icon indicating copy to clipboard operation
node-gitlab-2-github copied to clipboard

`TSError: ⨯ Unable to compile TypeScript:` on latest commit

Open tm1o2 opened this issue 9 months ago • 3 comments

With current commit, when make docker-run it shows an error as below:

% make docker-run
docker run node-gitlab-2-github:latest

> [email protected] start
> node node_modules/ts-node/dist/bin.js ./src/index.ts

/app/node_modules/ts-node/src/index.ts:750
    return new TSError(diagnosticText, diagnosticCodes);
           ^
TSError: ⨯ Unable to compile TypeScript:
src/index.ts(55,36): error TS2345: Argument of type 'typeof throttling' is not assignable to parameter of type 'OctokitPlugin'.
  Types of parameters 'octokit' and 'octokit' are incompatible.
    Type 'import("/app/node_modules/@octokit/rest/node_modules/@octokit/core/dist-types/index").Octokit' is not assignable to type 'import("/app/node_modules/@octokit/core/dist-types/index").Octokit'.
      The types of 'request.defaults(...).defaults(...).defaults(...).endpoint.DEFAULTS' are incompatible between these types.
        Type 'object & O & O & O & import("/app/node_modules/@octokit/rest/node_modules/@octokit/types/dist-types/RequestParameters").RequestParameters & { baseUrl: string; method: import("/app/node_modules/@octokit/rest/node_modules/@octokit/types/dist-types/RequestMethod").RequestMethod; url?: string; headers: import("/app/node...' is not assignable to type 'object & O & O & O & import("/app/node_modules/@octokit/types/dist-types/RequestParameters").RequestParameters & { baseUrl: string; method: import("/app/node_modules/@octokit/rest/node_modules/@octokit/types/dist-types/RequestMethod").RequestMethod; url?: string; headers: import("/app/node_modules/@octokit/types/dis...'.
          Type 'object & O & O & O & RequestParameters & { baseUrl: string; method: RequestMethod; url?: string; headers: RequestHeaders & { ...; }; mediaType: { ...; }; }' is not assignable to type '{ baseUrl: string; method: RequestMethod; url?: string; headers: RequestHeaders & { accept: string; "user-agent": string; }; mediaType: { format: string; previews: string[]; }; }'.
            Types of property 'mediaType' are incompatible.
              Type '{ format?: string; previews?: string[]; } & { format?: string; previews?: string[]; } & { format: string; previews?: string[]; }' is not assignable to type '{ format: string; previews: string[]; }'.
                Property 'previews' is optional in type '{ format?: string; previews?: string[]; } & { format?: string; previews?: string[]; } & { format: string; previews?: string[]; }' but required in type '{ format: string; previews: string[]; }'.

    at createTSError (/app/node_modules/ts-node/src/index.ts:750:12)
    at reportTSError (/app/node_modules/ts-node/src/index.ts:754:19)
    at getOutput (/app/node_modules/ts-node/src/index.ts:941:36)
    at Object.compile (/app/node_modules/ts-node/src/index.ts:1243:30)
    at Module.m._compile (/app/node_modules/ts-node/src/index.ts:1370:30)
    at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Object.require.extensions.<computed> [as .ts] (/app/node_modules/ts-node/src/index.ts:1374:12)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) {
  diagnosticText: "src/index.ts(55,36): error TS2345: Argument of type 'typeof throttling' is not assignable to parameter of type 'OctokitPlugin'.\n" +
    "  Types of parameters 'octokit' and 'octokit' are incompatible.\n" +
    `    Type 'import("/app/node_modules/@octokit/rest/node_modules/@octokit/core/dist-types/index").Octokit' is not assignable to type 'import("/app/node_modules/@octokit/core/dist-types/index").Octokit'.\n` +
    "      The types of 'request.defaults(...).defaults(...).defaults(...).endpoint.DEFAULTS' are incompatible between these types.\n" +
    `        Type 'object & O & O & O & import("/app/node_modules/@octokit/rest/node_modules/@octokit/types/dist-types/RequestParameters").RequestParameters & { baseUrl: string; method: import("/app/node_modules/@octokit/rest/node_modules/@octokit/types/dist-types/RequestMethod").RequestMethod; url?: string; headers: import("/app/node...' is not assignable to type 'object & O & O & O & import("/app/node_modules/@octokit/types/dist-types/RequestParameters").RequestParameters & { baseUrl: string; method: import("/app/node_modules/@octokit/rest/node_modules/@octokit/types/dist-types/RequestMethod").RequestMethod; url?: string; headers: import("/app/node_modules/@octokit/types/dis...'.\n` +
    `          Type 'object & O & O & O & RequestParameters & { baseUrl: string; method: RequestMethod; url?: string; headers: RequestHeaders & { ...; }; mediaType: { ...; }; }' is not assignable to type '{ baseUrl: string; method: RequestMethod; url?: string; headers: RequestHeaders & { accept: string; "user-agent": string; }; mediaType: { format: string; previews: string[]; }; }'.\n` +
    "            Types of property 'mediaType' are incompatible.\n" +
    "              Type '{ format?: string; previews?: string[]; } & { format?: string; previews?: string[]; } & { format: string; previews?: string[]; }' is not assignable to type '{ format: string; previews: string[]; }'.\n" +
    "                Property 'previews' is optional in type '{ format?: string; previews?: string[]; } & { format?: string; previews?: string[]; } & { format: string; previews?: string[]; }' but required in type '{ format: string; previews: string[]; }'.\n",
  diagnosticCodes: [ 2345 ]
}
make: *** [docker-run] Error 1

I think it has something with this commit. 126dd9f4de009c1fd0352a6dcbd543ecec6ecffe

When I tried to revert to below, it ran successfully. 84a62dbcb9cc00e300dccab5dd87c1ad5a492f1d

% git reset --hard 84a62dbcb9cc00e300dccab5dd87c1ad5a492f1d
HEAD is now at 84a62db Merge pull request #219 from mschoettle/add-weburl

% make build-image
% make docker-run

Environment: macOS 15.3.1 Docker version 24.0.2, build cb74dfc

Please check it:)

tm1o2 avatar Feb 21 '25 06:02 tm1o2

Thank you @tm1o2 This i also encountered today. The resolution above worked..

# unrelated, I run it like this
docker run -ti -v `pwd`/settings.ts:/app/settings.ts  -v `pwd`/out:/app/out docker.io/library/node-gitlab-2-github:latest

rbuckland avatar Feb 21 '25 06:02 rbuckland

Same issue here. I'm not running from Docker. I just had to re-run npm install after doing the git reset described above, and then everything worked perfectly again.

Willem3141 avatar Feb 25 '25 14:02 Willem3141

@spruce - the Pull request where Ocktokit has been upgraded to v21 has broken migrator. https://github.com/piceaTech/node-gitlab-2-github/pull/221

Would you be able to check, it seems we are now missing something else - that is. Pull from main, and run

make build-image
make docker-run

will immediately fail ; what else are we missing ?

Image

rbuckland avatar Feb 25 '25 23:02 rbuckland

Not using docker. Same issue.

npm version 10.9.0 node version 22.11.0

Just in case it helps narrow anything.

I rolled back to the commit before the octokit upgrade and it worked as expected. thanks for the tool.

/home/userName/node-gitlab-2-github/node_modules/ts-node/src/index.ts:750
    return new TSError(diagnosticText, diagnosticCodes);
           ^
TSError: ⨯ Unable to compile TypeScript:
src/index.ts:55:36 - error TS2345: Argument of type 'typeof throttling' is not assignable to parameter of type 'OctokitPlugin'.
  Types of parameters 'octokit' and 'octokit' are incompatible.
    Type 'import("/home/goofballtech/node-gitlab-2-github/node_modules/@octokit/rest/node_modules/@octokit/core/dist-types/index").Octokit' is not assignable to type 'import("/home/goofballtech/node-gitlab-2-github/node_modules/@octokit/core/dist-types/index").Octokit'.
      The types of 'request.defaults(...).defaults(...).defaults(...).endpoint.DEFAULTS' are incompatible between these types.
        Type 'object & O & O & O & import("/home/goofballtech/node-gitlab-2-github/node_modules/@octokit/rest/node_modules/@octokit/types/dist-types/RequestParameters").RequestParameters & { ...; }' is not assignable to type 'object & O & O & O & import("/home/goofballtech/node-gitlab-2-github/node_modules/@octokit/types/dist-types/RequestParameters").RequestParameters & { baseUrl: string; method: import("/home/goofballtech/node-gitlab-2-github/node_modules/@octokit/rest/node_modules/@octokit/types/dist-types/RequestMethod").RequestMetho...'.
          Type 'object & O & O & O & RequestParameters & { baseUrl: string; method: RequestMethod; url?: string; headers: RequestHeaders & { ...; }; mediaType: { ...; }; }' is not assignable to type '{ baseUrl: string; method: RequestMethod; url?: string; headers: RequestHeaders & { accept: string; "user-agent": string; }; mediaType: { format: string; previews: string[]; }; }'.
            Types of property 'mediaType' are incompatible.
              Type '{ format?: string; previews?: string[]; } & { format?: string; previews?: string[]; } & { format: string; previews?: string[]; }' is not assignable to type '{ format: string; previews: string[]; }'.
                Property 'previews' is optional in type '{ format?: string; previews?: string[]; } & { format?: string; previews?: string[]; } & { format: string; previews?: string[]; }' but required in type '{ format: string; previews: string[]; }'.

55 const MyOctokit = GitHubApi.plugin(throttling);
                                      ~~~~~~~~~~

    at createTSError (/home/goofballtech/node-gitlab-2-github/node_modules/ts-node/src/index.ts:750:12)
    at reportTSError (/home/goofballtech/node-gitlab-2-github/node_modules/ts-node/src/index.ts:754:19)
    at getOutput (/home/goofballtech/node-gitlab-2-github/node_modules/ts-node/src/index.ts:941:36)
    at Object.compile (/home/goofballtech/node-gitlab-2-github/node_modules/ts-node/src/index.ts:1243:30)
    at Module.m._compile (/home/goofballtech/node-gitlab-2-github/node_modules/ts-node/src/index.ts:1370:30)
    at node:internal/modules/cjs/loader:1689:10
    at Object.require.extensions.<computed> [as .ts] (/home/goofballtech/node-gitlab-2-github/node_modules/ts-node/src/index.ts:1374:12)
    at Module.load (node:internal/modules/cjs/loader:1318:32)
    at Function._load (node:internal/modules/cjs/loader:1128:12)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14) {
  diagnosticText: "\x1B[96msrc/index.ts\x1B[0m:\x1B[93m55\x1B[0m:\x1B[93m36\x1B[0m - \x1B[91merror\x1B[0m\x1B[90m TS2345: \x1B[0mArgument of type 'typeof throttling' is not assignable to parameter of type 'OctokitPlugin'.\n" +
    "  Types of parameters 'octokit' and 'octokit' are incompatible.\n" +
    `    Type 'import("/home/goofballtech/node-gitlab-2-github/node_modules/@octokit/rest/node_modules/@octokit/core/dist-types/index").Octokit' is not assignable to type 'import("/home/goofballtech/node-gitlab-2-github/node_modules/@octokit/core/dist-types/index").Octokit'.\n` +
    "      The types of 'request.defaults(...).defaults(...).defaults(...).endpoint.DEFAULTS' are incompatible between these types.\n" +
    `        Type 'object & O & O & O & import("/home/goofballtech/node-gitlab-2-github/node_modules/@octokit/rest/node_modules/@octokit/types/dist-types/RequestParameters").RequestParameters & { ...; }' is not assignable to type 'object & O & O & O & import("/home/goofballtech/node-gitlab-2-github/node_modules/@octokit/types/dist-types/RequestParameters").RequestParameters & { baseUrl: string; method: import("/home/goofballtech/node-gitlab-2-github/node_modules/@octokit/rest/node_modules/@octokit/types/dist-types/RequestMethod").RequestMetho...'.\n` +
    `          Type 'object & O & O & O & RequestParameters & { baseUrl: string; method: RequestMethod; url?: string; headers: RequestHeaders & { ...; }; mediaType: { ...; }; }' is not assignable to type '{ baseUrl: string; method: RequestMethod; url?: string; headers: RequestHeaders & { accept: string; "user-agent": string; }; mediaType: { format: string; previews: string[]; }; }'.\n` +
    "            Types of property 'mediaType' are incompatible.\n" +
    "              Type '{ format?: string; previews?: string[]; } & { format?: string; previews?: string[]; } & { format: string; previews?: string[]; }' is not assignable to type '{ format: string; previews: string[]; }'.\n" +
    "                Property 'previews' is optional in type '{ format?: string; previews?: string[]; } & { format?: string; previews?: string[]; } & { format: string; previews?: string[]; }' but required in type '{ format: string; previews: string[]; }'.\n" +
    '\n' +
    '\x1B[7m55\x1B[0m const MyOctokit = GitHubApi.plugin(throttling);\n' +
    '\x1B[7m  \x1B[0m \x1B[91m                                   ~~~~~~~~~~\x1B[0m\n',
  diagnosticCodes: [ 2345 ]
}

TSaucier1 avatar Mar 07 '25 21:03 TSaucier1

#226 should hopefully fix this. At least I upgraded various octokit packages myself and have been running it for a few migrations.

mschoettle avatar May 16 '25 19:05 mschoettle

I'm using [email protected], [email protected] and I'm seeing the same problem still.

jarrah42 avatar Jun 09 '25 16:06 jarrah42

I'm using [email protected], [email protected] and I'm seeing the same problem still.

Same with [email protected] and node @v23.9.0 and latest commit (a562e12cc7cc43739cee912ed59a4d65bff8391b) This worked for me

git reset --hard 84a62dbcb9cc00e300dccab5dd87c1ad5a492f1d
npm i

scim037 avatar Jun 10 '25 07:06 scim037

Can you try with node v22? The Dockerfile is based on v22 and I have successfully run it with that.

https://github.com/piceaTech/node-gitlab-2-github/blob/a562e12cc7cc43739cee912ed59a4d65bff8391b/Dockerfile#L9

mschoettle avatar Jun 10 '25 14:06 mschoettle

I don't use Docker. It happens natively on the OS level.

scim037 avatar Jun 10 '25 15:06 scim037

That's ok. Can you tried it with node 22 on your machine then?

mschoettle avatar Jun 11 '25 18:06 mschoettle

Sure

node --version
v22.9.0
git log -1
commit a562e12cc7cc43739cee912ed59a4d65bff8391b (HEAD -> master, origin/master, origin/HEAD)
Merge: 62ba72c a6c3cb6
Author: Felix Fichte <[email protected]>
Date:   Tue May 27 14:47:11 2025 +0200

    Merge branch 'mschoettle-upgrade-octokit'
npm i
npm warn deprecated @gitbeaker/[email protected]: Please use its successor @gitbeaker/rest
npm warn deprecated [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.

> [email protected] prepare
> husky install

husky - Git hooks installed

added 246 packages, and audited 247 packages in 4s

57 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
Error
npm run start

> [email protected] start
> node node_modules/ts-node/dist/bin.js ./src/index.ts

/home/user/node-gitlab-2-github/node_modules/ts-node/src/index.ts:750
    return new TSError(diagnosticText, diagnosticCodes);
           ^
TSError: ⨯ Unable to compile TypeScript:
src/index.ts:55:36 - error TS2345: Argument of type 'typeof throttling' is not assignable to parameter of type 'OctokitPlugin'.
  Types of parameters 'octokit' and 'octokit' are incompatible.
    Type 'import("/home/user/node-gitlab-2-github/node_modules/@octokit/rest/node_modules/@octokit/core/dist-types/index").Octokit' is not assignable to type 'import("/home/user/node-gitlab-2-github/node_modules/@octokit/core/dist-types/index").Octokit'.
      The types returned by 'request.defaults(...).defaults(...).defaults(...)(...)' are incompatible between these types.
        Type 'Promise<import("/home/user/node-gitlab-2-github/node_modules/@octokit/rest/node_modules/@octokit/request/node_modules/@octokit/types/dist-types/OctokitResponse").OctokitResponse<any, number>>' is not assignable to type 'Promise<import("/home/user/node-gitlab-2-github/node_modules/@octokit/request/node_modules/@octokit/types/dist-types/OctokitResponse").OctokitResponse<any, number>>'.
          Property 'retryCount' is missing in type 'import("/home/user/node-gitlab-2-github/node_modules/@octokit/rest/node_modules/@octokit/request/node_modules/@octokit/types/dist-types/OctokitResponse").OctokitResponse<any, number>' but required in type 'import("/home/user/node-gitlab-2-github/node_modules/@octokit/request/node_modules/@octokit/types/dist-types/OctokitResponse").OctokitResponse<any, number>'.

55 const MyOctokit = GitHubApi.plugin(throttling);
                                      ~~~~~~~~~~

  node_modules/@octokit/plugin-throttling/dist-types/index.d.ts:15:9
    15         retryCount: number;
               ~~~~~~~~~~
    'retryCount' is declared here.

    at createTSError (/home/user/node-gitlab-2-github/node_modules/ts-node/src/index.ts:750:12)
    at reportTSError (/home/user/node-gitlab-2-github/node_modules/ts-node/src/index.ts:754:19)
    at getOutput (/home/user/node-gitlab-2-github/node_modules/ts-node/src/index.ts:941:36)
    at Object.compile (/home/user/node-gitlab-2-github/node_modules/ts-node/src/index.ts:1243:30)
    at Module.m._compile (/home/user/node-gitlab-2-github/node_modules/ts-node/src/index.ts:1370:30)
    at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
    at Object.require.extensions.<computed> [as .ts] (/home/user/node-gitlab-2-github/node_modules/ts-node/src/index.ts:1374:12)
    at Module.load (node:internal/modules/cjs/loader:1317:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1127:12)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14) {
  diagnosticText: "\x1B[96msrc/index.ts\x1B[0m:\x1B[93m55\x1B[0m:\x1B[93m36\x1B[0m - \x1B[91merror\x1B[0m\x1B[90m TS2345: \x1B[0mArgument of type 'typeof throttling' is not assignable to parameter of type 'OctokitPlugin'.\n" +
    "  Types of parameters 'octokit' and 'octokit' are incompatible.\n" +
    `    Type 'import("/home/user/node-gitlab-2-github/node_modules/@octokit/rest/node_modules/@octokit/core/dist-types/index").Octokit' is not assignable to type 'import("/home/user/node-gitlab-2-github/node_modules/@octokit/core/dist-types/index").Octokit'.\n` +
    "      The types returned by 'request.defaults(...).defaults(...).defaults(...)(...)' are incompatible between these types.\n" +
    `        Type 'Promise<import("/home/user/node-gitlab-2-github/node_modules/@octokit/rest/node_modules/@octokit/request/node_modules/@octokit/types/dist-types/OctokitResponse").OctokitResponse<any, number>>' is not assignable to type 'Promise<import("/home/user/node-gitlab-2-github/node_modules/@octokit/request/node_modules/@octokit/types/dist-types/OctokitResponse").OctokitResponse<any, number>>'.\n` +
    `          Property 'retryCount' is missing in type 'import("/home/user/node-gitlab-2-github/node_modules/@octokit/rest/node_modules/@octokit/request/node_modules/@octokit/types/dist-types/OctokitResponse").OctokitResponse<any, number>' but required in type 'import("/home/user/node-gitlab-2-github/node_modules/@octokit/request/node_modules/@octokit/types/dist-types/OctokitResponse").OctokitResponse<any, number>'.\n` +
    '\n' +
    '\x1B[7m55\x1B[0m const MyOctokit = GitHubApi.plugin(throttling);\n' +
    '\x1B[7m  \x1B[0m \x1B[91m                                   ~~~~~~~~~~\x1B[0m\n' +
    '\n' +
    '  \x1B[96mnode_modules/@octokit/plugin-throttling/dist-types/index.d.ts\x1B[0m:\x1B[93m15\x1B[0m:\x1B[93m9\x1B[0m\n' +
    '    \x1B[7m15\x1B[0m         retryCount: number;\n' +
    '    \x1B[7m  \x1B[0m \x1B[96m        ~~~~~~~~~~\x1B[0m\n' +
    "    'retryCount' is declared here.\n",
  diagnosticCodes: [ 2345 ]
}

scim037 avatar Jun 12 '25 07:06 scim037

Can you try the fix in #236?

mschoettle avatar Jun 16 '25 13:06 mschoettle

That fixed the original error with the throttle plugin. But I got a new one

npm run start

> [email protected] start
> node node_modules/ts-node/dist/bin.js ./src/index.ts

/home/user/test/node-gitlab-2-github/node_modules/ts-node/src/index.ts:750
    return new TSError(diagnosticText, diagnosticCodes);
           ^
TSError: ⨯ Unable to compile TypeScript:
src/gitlabHelper.ts:156:66 - error TS2339: Property 'showConfiguration' does not exist on type 'MergeRequestApprovals<false>'.

156       let approvals = await this.gitlabApi.MergeRequestApprovals.showConfiguration(
                                                                     ~~~~~~~~~~~~~~~~~

    at createTSError (/home/user/test/node-gitlab-2-github/node_modules/ts-node/src/index.ts:750:12)
    at reportTSError (/home/user/test/node-gitlab-2-github/node_modules/ts-node/src/index.ts:754:19)
    at getOutput (/home/user/test/node-gitlab-2-github/node_modules/ts-node/src/index.ts:941:36)
    at Object.compile (/home/user/test/node-gitlab-2-github/node_modules/ts-node/src/index.ts:1243:30)
    at Module.m._compile (/home/user/test/node-gitlab-2-github/node_modules/ts-node/src/index.ts:1370:30)
    at loadTS (node:internal/modules/cjs/loader:1826:10)
    at Object.require.extensions.<computed> [as .ts] (/home/user/test/node-gitlab-2-github/node_modules/ts-node/src/index.ts:1374:12)
    at Module.load (node:internal/modules/cjs/loader:1469:32)
    at Module._load (node:internal/modules/cjs/loader:1286:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14) {
  diagnosticText: "\x1B[96msrc/gitlabHelper.ts\x1B[0m:\x1B[93m156\x1B[0m:\x1B[93m66\x1B[0m - \x1B[91merror\x1B[0m\x1B[90m TS2339: \x1B[0mProperty 'showConfiguration' does not exist on type 'MergeRequestApprovals<false>'.\n" +
    '\n' +
    '\x1B[7m156\x1B[0m       let approvals = await this.gitlabApi.MergeRequestApprovals.showConfiguration(\n' +
    '\x1B[7m   \x1B[0m \x1B[91m                                                                 ~~~~~~~~~~~~~~~~~\x1B[0m\n',
  diagnosticCodes: [ 2339 ]
}

scim037 avatar Jun 17 '25 07:06 scim037

node version v20.19.2. npm version 10.8.2

Me too here, after upgraded @octokit/types as suggested in #236 , I got this new error:

/Code/node-gitlab-2-github/node_modules/ts-node/src/index.ts:750
    return new TSError(diagnosticText, diagnosticCodes);
           ^
TSError: ⨯ Unable to compile TypeScript:
src/gitlabHelper.ts:156:66 - error TS2339: Property 'showConfiguration' does not exist on type 'MergeRequestApprovals<false>'.

156       let approvals = await this.gitlabApi.MergeRequestApprovals.showConfiguration(
                                                                     ~~~~~~~~~~~~~~~~~

    at createTSError (/Users/benjamin/Code/node-gitlab-2-github/node_modules/ts-node/src/index.ts:750:12)
    at reportTSError (/Users/benjamin/Code/node-gitlab-2-github/node_modules/ts-node/src/index.ts:754:19)
    at getOutput (/Users/benjamin/Code/node-gitlab-2-github/node_modules/ts-node/src/index.ts:941:36)
    at Object.compile (/Users/benjamin/Code/node-gitlab-2-github/node_modules/ts-node/src/index.ts:1243:30)
    at Module.m._compile (/Users/benjamin/Code/node-gitlab-2-github/node_modules/ts-node/src/index.ts:1370:30)
    at Module._extensions..js (node:internal/modules/cjs/loader:1613:10)
    at Object.require.extensions.<computed> [as .ts] (/Users/benjamin/Code/node-gitlab-2-github/node_modules/ts-node/src/index.ts:1374:12)
    at Module.load (node:internal/modules/cjs/loader:1275:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1096:12)
    at Module.require (node:internal/modules/cjs/loader:1298:19) {
  diagnosticText: "\x1B[96msrc/gitlabHelper.ts\x1B[0m:\x1B[93m156\x1B[0m:\x1B[93m66\x1B[0m - \x1B[91merror\x1B[0m\x1B[90m TS2339: \x1B[0mProperty 'showConfiguration' does not exist on type 'MergeRequestApprovals<false>'.\n" +
    '\n' +
    '\x1B[7m156\x1B[0m       let approvals = await this.gitlabApi.MergeRequestApprovals.showConfiguration(\n' +
    '\x1B[7m   \x1B[0m \x1B[91m                                                                 ~~~~~~~~~~~~~~~~~\x1B[0m\n',
  diagnosticCodes: [ 2339 ]
}

iconben avatar Jun 17 '25 15:06 iconben

Sorry, I introduced an error in that part with a previous PR. You also need the fix in #237.

mschoettle avatar Jun 17 '25 18:06 mschoettle

Both fixes combined work

git log -2

commit 83e02b02686fefbc6ac22e53fc7c57239393141e (pr-237)
Author: Matthias Schoettle <[email protected]>
Date:   Thu Feb 27 14:46:17 2025 -0500

    Use correct endpoint for determining MR approvals

commit a10b1c5f4c58ee8e206bc01aca766087f1461f5a (pr-236)
Author: Matthias Schoettle <[email protected]>
Date:   Mon Jun 16 09:18:48 2025 -0400

    Bump @octokit/types

npm i
npm warn deprecated @gitbeaker/[email protected]: Please use its successor @gitbeaker/rest
npm warn deprecated [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.

> [email protected] prepare
> husky install

husky - Git hooks installed

added 234 packages, and audited 235 packages in 4s

57 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
cp sample_settings.ts settings.ts
npm run start

> [email protected] start
> node node_modules/ts-node/dist/bin.js ./src/index.ts



You have to enter your GitLab private token in the settings.js file.

scim037 avatar Jun 18 '25 07:06 scim037