node-gitlab-2-github icon indicating copy to clipboard operation
node-gitlab-2-github copied to clipboard

new Settings for migration when assignee users don't exist and S3 isn't used for attachment storage

Open bensons opened this issue 4 years ago • 3 comments

Created settings for clearing issue assignees, bypassing S3 bucket upload, saving issue attachments locally, and rewriting attachment URLs in issue content. Fixed problem downloading attachments with international characters by encoding attachment download URIs.

bensons avatar Sep 30 '21 22:09 bensons

Very cool commit. I have a few notes from my side if I could:

  1. Would be great if you could split clearIssueAssignment, attachment URI encoding and S3 stuff so they can be applied separately.
  2. useS3 flag conflicts with overrideURL flag. I would use overrideURL only if useS3 is FALSE

ujos avatar Oct 19 '21 12:10 ujos

@bensons Any comments regarding the review?

spruce avatar Dec 06 '21 14:12 spruce

I've used the code in this PR to transfer the images to a hidden ref in the repo and use a relative link to have them show up in the issues, i.e. something like ../blob/<hash>/path/to/image.png?raw=true (cf. https://github.com/github/docs/pull/17479).

Since the PR does not merge cleanly anymore, here is an up-to-date version if it helps anyone (I don't have time right now to clean it up and submit a proper PR): https://github.com/piceaTech/node-gitlab-2-github/compare/master...phil-blain:fixes. The only thing I did not reapply is the clearIssueAssignment setting.

I've also removed the use of the githubRepoId in the relative path as this solves a chicken-and-egg problem where if you don't know the repo ID before running the conversion, you can't use it in the overrideURL setting...

phil-blain avatar May 02 '22 20:05 phil-blain