Move to Bootstrap 4

[GCorbel]

Bootstrap 4 is available and we should move to the new version. We have to follow this path : https://getbootstrap.com/docs/4.0/migration/ .

I think it would be nice to find a way to be compatible with both, like simple_form do in Ruby.

I'm not sure how we can do. We can add an object we can can change in config/environment.js like this :

ENV['ember-rapid-forms'] = {
  formControlClass: 'form-group`,
  formText: 'help-block`,
  // ....
}

This allows to change classes which should be enough for Bootstrap 4 but it can be cool to find a way to be compatible with other frameworks allows to change wrappers. I will think to a way to do it.

@spruce and @slannigan what you think?

[spruce]

Some thoughts: I would like to have a way to not do any configuration per default. Maybe only set which version should be used. Default to v4 but being able to set back to v3. Or maybe maintain an old branch with v3 and v4 on the next major?

How to you mean the change wrappers? zurb foundation and stuff? I think that would need much refactor no?

[GCorbel]

I agree with the "bootstrap 4" by default. Maybe we can add a generator to generate a config file with stuffs for bootstrap 3 or custom config.

I don't really know Zurb or others frameworks. I will just check if we can do it or not but I think it will require more changes.

About separate branches, it will be hard to maintain.

Le dim. 22 avr. 2018 5:22 PM, Felix Fichte [email protected] a écrit :

Some thought: I would like to have a way to not do any configuration per default. Maybe only set which version should be used. Default to v4 but being able to set back to v3. Or maybe maintain an old branch with v3 and v4 on the next major?

How to you mean the change wrappers? zurb foundation and stuff? I think that would need much refactor no?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/piceaTech/ember-rapid-forms/issues/192#issuecomment-383413402, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPHSUu2SAsHYamY_t2usBoj7NRYQS7qks5trPSBgaJpZM4Td643 .