piccolo_admin synchronise the filters with the GET parameters

Related to #42 and #163

Jun 02 '22 19:06 sinisaos

Codecov Report

Merging #165 (9c5805d) into master (ba9da95) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   93.31%   93.31%           
=======================================
  Files           5        5           
  Lines         359      359           
=======================================
  Hits          335      335           
  Misses         24       24

Jun 02 '22 19:06 codecov-commenter

@dantownsend Did you have time to try this?

Jun 06 '22 06:06 sinisaos

@sinisaos Not yet, will have a look today.

Jun 06 '22 07:06 dantownsend

This is cool.

I came across an issue though - even though the values in the URL are applied as filters, they don't show in the filter sidebar for some reason.

https://user-images.githubusercontent.com/350976/172550468-d74f7d72-06a0-483e-9005-d9d3f19a1035.mov

I'm not sure why - will have to investigate more.

Jun 08 '22 06:06 dantownsend

@dantownsend You're right. Sorry, I didn't watch it at all. I focused on being able to get back to the filtered view after pressing Back button.

Jun 08 '22 07:06 sinisaos

@dantownsend Can you try this with last commit? It's keeping the form data after changing the route. Work with input type text and number, doesn't work on select.

Result is:

https://user-images.githubusercontent.com/30960668/174348726-6bf6a22f-d2cf-499f-b972-d6c40a156cb2.mp4

Jun 11 '22 19:06 sinisaos

Sorry I haven't had a change to look into this yet - will get it in the next release.

Jul 04 '22 09:07 dantownsend

@dantownsend Another try with history.state. The main problem is that the duration and keySearch widget are not in sync with history.state, so I changed that. The code is not the prettiest, but it works. Fell free to change that.

https://user-images.githubusercontent.com/30960668/180741650-a18b8785-dda9-48e1-a668-c8a8276eb299.mp4

Jul 25 '22 09:07 sinisaos

@sinisaos Cool, thanks - it looks like it works well in the video.

Jul 25 '22 09:07 dantownsend

@dantownsend It works, but the code is not the nicest.

Jul 25 '22 09:07 sinisaos