terraform-google-nomad icon indicating copy to clipboard operation
terraform-google-nomad copied to clipboard

Published 20 hours ago • verified publisher icon picatz

Consul configuration defines unused options in server and client

Open picatz opened this issue 2 years ago • 2 comments

Client agents do not need to enable connect, this is only used on servers:

Enabling Connect requires changing the configuration of only your Consul servers (not client agents).

https://github.com/picatz/terraform-google-nomad/blob/0db159e7c90367553c3c9b61c3a892418d686e36/packer/configs/consul/client.hcl#L30-L32

Servers do not need to enable the gRPC port, this is only used on clients:

https://github.com/picatz/terraform-google-nomad/blob/0db159e7c90367553c3c9b61c3a892418d686e36/packer/configs/consul/server.hcl#L17

There might be others, but these should definitely be removed.

picatz avatar Mar 03 '22 20:03 picatz

Hi,I would like to contribute

lordsonfernando avatar Mar 09 '22 17:03 lordsonfernando

👋 Hello @lordsonfernando, PRs are welcome!

picatz avatar Mar 15 '22 23:03 picatz