manual-connections icon indicating copy to clipboard operation
manual-connections copied to clipboard

save port and paylaod_signature to files

Open StudioEtrange opened this issue 4 years ago • 4 comments

The purpose is like for saving token in a file : by saving payload and signature and port we can use these values outside of these scripts

Need that at least for port because the only way to get the port is to read terminal, not easily usable in a lot of way and store port and payload_signature in files do not broke actual usage I think

Thanx !

StudioEtrange avatar Jan 31 '21 02:01 StudioEtrange

Been running with this (manually) merged for nearly a year now. Provides a critical piece of functionality. Would really like to see it merged!

jswclw avatar Jan 21 '22 11:01 jswclw

Been running with this (manually) merged for nearly a year now. Provides a critical piece of functionality. Would really like to see it merged!

Thank you for the confirmation. I think the idea is good and we should merge. However we could improve the structure a bit:

  • structure everything under the same directory: /opt/piavpn-manual/port_forwarding
  • name files as follows:
    • /opt/piavpn-manual/port_forwarding/payload_and_signature
    • /opt/piavpn-manual/port_forwarding/port
    • /opt/piavpn-manual/port_forwarding/expires_at

Please confirm this is acceptable. If yes, we can modify the merge request with the new data, test again and merge.

g00nix avatar Jan 21 '22 13:01 g00nix

This sounds good to me!

On Fri, Jan 21, 2022 at 8:46 AM goonix @.***> wrote:

Been running with this (manually) merged for nearly a year now. Provides a critical piece of functionality. Would really like to see it merged!

Thank you for the confirmation. I think the idea is good and we should merge. However we could improve the structure a bit:

  • structure everything under the same directory: /opt/piavpn-manual/port_forwarding
  • name files as follows:
    • /opt/piavpn-manual/port_forwarding/payload_and_signature
    • /opt/piavpn-manual/port_forwarding/port
    • /opt/piavpn-manual/port_forwarding/expires_at

Please confirm this is acceptable. If yes, we can modify the merge request with the new data, test again and merge.

— Reply to this email directly, view it on GitHub https://github.com/pia-foss/manual-connections/pull/91#issuecomment-1018518472, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABW26P67K5W2BJ3RIVCGADDUXFPSFANCNFSM4W24JTXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

jswclw avatar Jan 23 '22 20:01 jswclw

any news on this PR ?

StudioEtrange avatar Mar 14 '24 02:03 StudioEtrange