manual-connections icon indicating copy to clipboard operation
manual-connections copied to clipboard

fix path to cert file into dynamic value

Open StudioEtrange opened this issue 4 years ago • 4 comments

cert file path must be dynamicly computed into absolute path to be independent of the current running dir

StudioEtrange avatar Jan 29 '21 03:01 StudioEtrange

I guess this solved the bug where the user runs the scripts from another folder and the scripts can not find the CA file. Please confirm this is the case, and we will run some QA on this PR and approve it.

g00nix avatar Jan 30 '21 12:01 g00nix

In short : Yes that is the case !

And solved other situations relative to the situation when we use scripts independently (running get_token alone or port_forwarding alone) from whatever current running directory is, and help when integrating the scripts in other script for automation purpose

StudioEtrange avatar Jan 30 '21 14:01 StudioEtrange

Sorry for the long wait time. I think the common practice for the variable name is script_dir, not CURRENT_FILE_DIR. What do you think?

g00nix avatar Feb 19 '22 02:02 g00nix

CAPS characters is for global variable

StudioEtrange avatar Feb 19 '22 22:02 StudioEtrange