Pierre Goiffon

Results 130 comments of Pierre Goiffon

rebased & force pushed to solve conflicts

Functional review : OK, but for 2.7.8 / 3.0.2

Technically this seems good I'll need to have the product team opinion on this though...

Setting this PR to reviewed on next functionnal review meeting (next week) : that will be a good place to ask Erwan :o)

Ok thanks :) Will be discussed during next functionnal review !

Accepted in technical review. But we should check if `%f` is used elsewhere ?

Just used in \EmailReplica::MakeMessageId (combodo-email-synchro) Will do a PR for this module, too

Many thanks Vladimir ! Will have a look with @rquetiez and/or @eespie before planning this PR for review.

Hello, I had a look to the code with @eespie and this seems perfect to us ! We would like to add a phpunit test though... We can code it...