Pierre Goiffon

Results 130 comments of Pierre Goiffon

Processed today in technical review : good to go for functional review next week !

Discussed with Stephane : we will switch the check to warning so it will become non blocking. The information will still be there, and we won't block setup wrongly !

New message when dir isn't writable moved to warning : ![image](https://user-images.githubusercontent.com/8947448/189954139-eda2e2a5-d50a-40ab-948f-1dc60cfea8c3.png) And after opening the details : ![image](https://user-images.githubusercontent.com/8947448/189954190-ccc76a1a-1b20-46f0-9e52-b1c6d776f114.png)

Hello, Do you need to see the base64 content ? Or should we replace it with the mention "blob" and value size maybe ?

Hello, Sorry I moved this PR to the "pending contributor" state and it was a bad idea... I'll change the state again so that this PR will be processed on...

Reviewed during PR technical review : actually the main problem is that we are getting raw data and display them as is... This will create problems also for HTML attributes...

Thanks Thomas ! Would you also replace the base64 value by something else, maybe the size ? To display the value properly you could use `\SetupUtils::HumanReadableSize`

> I have done the change Thanks ! > I feel like we still need to show the first x bytes (encoded) Can you give some use cases where it...

:D I understand ! There's no doubt this is far from ideal now, and still after this PR. But your PR improves things a bit, for us it's better now...