Pierre Goiffon

Results 130 comments of Pierre Goiffon

You may use the new KeyValueStore class to store the count ? It might be easier, and more flexible ?

I've just removed the milestone as 3.0.0 was delivered some time ago ! @Molkobain is this PR really in the pending Combodo state ?

Although this is still a work in progress, I'm adding this PR to our project so that we don't loose track of it !

For now, \SetupUtils::CheckWritableDirs only checks under APPROOT :(

Now the readonly is correctly detected ! Rebased the branch by the way O:)

Error message : ![image](https://user-images.githubusercontent.com/8947448/177366846-588a9e8e-57e5-4b00-bab7-45e47674a66a.png) And success message : ![image](https://user-images.githubusercontent.com/8947448/177367052-f761bae7-3838-4e37-8036-e49b981d6b38.png)

> Discussed during technical review: Why not include the directory test in the already existing `self::CheckWritableDirs()` method? Is it just for the specific error message? That was what I wrote...

Yep, adding a phpdoc block to \SetupUtils::CheckWritableDirs would be a good idea ! I'll do it in the upcoming days