web
web copied to clipboard
Better user interface to edit reverse DNS servers (`dns.revServers`)
What does this PR aim to accomplish?
Replace the current single <textarea> with a table.
Each reverse server will be in a separate row and each field will be in a separate table cell.
A small legend will improve usability (maybe we will need to change the help text).
NOTE:
~~Depends on https://github.com/pi-hole/web/pull/2885~~ (already merged)
How does this PR accomplish the above?
Using datatables plugin and a few functions to deal with dns.revServers entries.
By submitting this pull request, I confirm the following:
- I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
- I have commented my proposed changes within the code and I have tested my changes.
- I am willing to help maintain this change if there are issues with it later.
- It is compatible with the EUPL 1.2 license
- I have squashed any insignificant commits. (
git rebase) - I have checked that another pull request for this purpose does not exist.
- I have considered, and confirmed that this submission will be valuable to others.
- I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
- I give this submission freely, and claim no ownership to its content.
- [x] I have read the above and my PR is ready for review. Check this box to confirm
The first thing I noticed was my currently defined revServer cannot be disabled.
This is expected... In the current state, this PR can only add and delete entries. I didn't create functions to edit fields (this checkbox is just a nice way to display true/false values).
I hope the reason is: because you are adding editing
This is in my todo list.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved.