web icon indicating copy to clipboard operation
web copied to clipboard

feature request web ui display total requests allowed

Open mhussaincov opened this issue 4 years ago • 8 comments

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

{Replace this with a number from 1 to 10. 1 being not familiar, and 10 being very familiar} 1


Expected behaviour:

{A detailed description of what you expect to see}

Actual behaviour:

{A detailed description and/or screenshots of what you do see}

when you load the pi-hole admin page you can see total requests and requests blocked, would it be possable for the ui to display total allowed requests?

Steps to reproduce:

{Detailed steps of how we can reproduce this} log in to the pi-hole admin interface and you will see the total requests and blocked requests this is accessible with orca. Debug token provided by uploading pihole -d log:

{Alphanumeric token}

Troubleshooting undertaken, and/or other relevant information:

{Steps of what you have done to fix this}

mhussaincov avatar Mar 25 '20 16:03 mhussaincov

an update, it seembs that total requests for 24 hours are displayed but in a way that it is not accessible to screen readers sigh would it be possible to make that accessible like the bit where total requests for all clients is displayed? I hope this makes sence,

mhussaincov avatar Mar 25 '20 16:03 mhussaincov

sorry finger slipped when submitting

mhussaincov avatar Mar 25 '20 16:03 mhussaincov

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

github-actions[bot] avatar Jan 11 '22 19:01 github-actions[bot]

Adding Bug to this so that it's not going to be stale again. I think accessible issues should not auto-closed, but needs active closing by affected people after an issue is solved.

yubiuser avatar Jan 12 '22 21:01 yubiuser

This seems to be most easily fixed by adding a variable to the API (in /stats/summary for v6) called "allowed" or something. Then it should be easy to just add the extra code to add it to the GUI. Otherwise doing some quick math subtracting the blocked queries from the total queries.

Might be a good candidate for v6?

garakangas avatar Jan 01 '24 12:01 garakangas