docs
docs copied to clipboard
Fix grammar, style, and formatting in Approximate Matching doc
What does this PR aim to accomplish?:
Tidy the wording and syntax in docs/regex/approximate.md as some of it didn't make sense or was inconsistent
By submitting this pull request, I confirm the following:
- I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
- I have commented my proposed changes within the code and I have tested my changes.
- I am willing to help maintain this change if there are issues with it later.
- It is compatible with the EUPL 1.2 license
- I have squashed any insignificant commits. (
git rebase) - I have checked that another pull request for this purpose does not exist.
- I have considered, and confirmed that this submission will be valuable to others.
- I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
- I give this submission freely, and claim no ownership to its content.
- [x] I have read the above and my PR is ready for review. Check this box to confirm
Deploy Preview for pihole-docs ready!
| Name | Link |
|---|---|
| Latest commit | bec4096f41d7cf9fb32bac00842219ce8ac3803c |
| Latest deploy log | https://app.netlify.com/projects/pihole-docs/deploys/687f9bbe79fd6000082781d6 |
| Deploy Preview | https://deploy-preview-1240--pihole-docs.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
I'd like to know @DL6ER opinion here, because he is the original author of this page.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved.
@rdwebdesign @DL6ER happy with my changes?
One formal change: please squash down all your commits
@yubiuser I don't think I can squash from the UI, are you able to squash when merging?
I don't see any issues, but I'm also not a native speaker. Maybe @PromoFaux can check the text to make sure.
Looks good to me
And yes, we can do a squash merge - no worries there
Thanks, and thanks all for all your work on this project!