docs icon indicating copy to clipboard operation
docs copied to clipboard

Fix grammar, style, and formatting in Approximate Matching doc

Open its-dave opened this issue 6 months ago • 2 comments

What does this PR aim to accomplish?:

Tidy the wording and syntax in docs/regex/approximate.md as some of it didn't make sense or was inconsistent


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • [x] I have read the above and my PR is ready for review. Check this box to confirm

its-dave avatar May 04 '25 23:05 its-dave

Deploy Preview for pihole-docs ready!

Name Link
Latest commit bec4096f41d7cf9fb32bac00842219ce8ac3803c
Latest deploy log https://app.netlify.com/projects/pihole-docs/deploys/687f9bbe79fd6000082781d6
Deploy Preview https://deploy-preview-1240--pihole-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar May 04 '25 23:05 netlify[bot]

I'd like to know @DL6ER opinion here, because he is the original author of this page.

rdwebdesign avatar May 18 '25 01:05 rdwebdesign

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 18 '25 03:07 github-actions[bot]

Conflicts have been resolved.

github-actions[bot] avatar Jul 19 '25 16:07 github-actions[bot]

@rdwebdesign @DL6ER happy with my changes?

its-dave avatar Jul 19 '25 16:07 its-dave

One formal change: please squash down all your commits

yubiuser avatar Jul 19 '25 16:07 yubiuser

@yubiuser I don't think I can squash from the UI, are you able to squash when merging?

its-dave avatar Jul 19 '25 19:07 its-dave

I don't see any issues, but I'm also not a native speaker. Maybe @PromoFaux can check the text to make sure.

rdwebdesign avatar Jul 19 '25 22:07 rdwebdesign

Looks good to me

PromoFaux avatar Jul 19 '25 22:07 PromoFaux

And yes, we can do a squash merge - no worries there

PromoFaux avatar Jul 19 '25 22:07 PromoFaux

Thanks, and thanks all for all your work on this project!

its-dave avatar Jul 19 '25 22:07 its-dave