docker-pi-hole icon indicating copy to clipboard operation
docker-pi-hole copied to clipboard

If provided lighttpd will bind to ServerIPv6 in host mode

Open jnss95 opened this issue 6 years ago • 2 comments

Description

Bugfix of Issues #163 and #239

Motivation and Context

Since I am already running a nginx instance on Port 80 on my machine, I wanted to bind pihole onto a different pair of IP addresses. This worked fine for IPv4 using the ServerIP environment variable, but failed for IPv6 because lighttpd still tried to bind to [::].

How Has This Been Tested?

Tested on Ubuntu Server 18.40 running Docker 19.03.5 on an AMD64 host system.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.

jnss95 avatar Dec 10 '19 13:12 jnss95

If you pull in the latest code from dev branch it should resolve the CI test failures (and switch from travis to Circle CI)

diginc avatar Jan 02 '20 19:01 diginc

If you pull in the latest code from dev branch it should resolve the CI test failures (and switch from travis to Circle CI)

Done

jnss95 avatar Jan 04 '20 11:01 jnss95

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 19 '22 20:12 github-actions[bot]

Existing merge conflicts have not been addressed. This PR is considered abandoned.

github-actions[bot] avatar Jan 19 '23 10:01 github-actions[bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/support-changing-admin-bind-address-to-something-else-than-ftlconf-local-ipv4/60632/21

pralor-bot avatar Jan 22 '23 19:01 pralor-bot

@Xeranor - sorry this kind of fell by the wayside - would you like to bring it up to date with the latest changes?

PromoFaux avatar Jan 22 '23 19:01 PromoFaux