docker-pi-hole icon indicating copy to clipboard operation
docker-pi-hole copied to clipboard

Look into using `tini` init system

Open PromoFaux opened this issue 2 years ago • 3 comments

PromoFaux avatar Jul 24 '23 11:07 PromoFaux

looks like tini implementation is rather simple: add tini to package and change ENTRYPOINT [ "/usr/bin/start.sh"] to

ENTRYPOINT [ "tini", "--" ]
CMD [ "/usr/bin/start.sh" ]

according to https://computingforgeeks.com/use-tini-init-system-in-docker-containers/?expand_article=1 much easier to use that s6svc or supervisorctl.

Where is the catch ?

edgd1er avatar Jul 24 '23 21:07 edgd1er

Where is the catch ?

I've been too lazy to remember to look into it, is all 😉

PromoFaux avatar Jul 24 '23 21:07 PromoFaux

v6 is a big overhaul, I understand time is not limitless :) I realise that the phrase "where is the catch ?" may be be understood as an unpleasant remark. This is absolutely not my intention.

edgd1er avatar Jul 24 '23 21:07 edgd1er

Should this issue be closed since it seems to be done or at least no longer relevant?

magikid avatar Jul 03 '24 18:07 magikid